Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

Updates from head #1

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updated giphy provider to add https:// to iframe url
numinos1 committed Jun 19, 2017
commit c757b4b26355f49386de162feac991e0f3988c38
5 changes: 3 additions & 2 deletions providers/domains_gh.js
Original file line number Diff line number Diff line change
@@ -16,6 +16,8 @@ module.exports = [
}
}),

// <iframe src="https://giphy.com/embed/xUPGcHXN6vOiJA77ck" width="480" height="270" frameBorder="0" class="giphy-embed" allowFullScreen></iframe>
// <p><a href="https://giphy.com/gifs/bbc-cute-animal-xUPGcHXN6vOiJA77ck">via GIPHY</a></p>
Provider.extend({
name: "giphy",
type: "video",
@@ -26,9 +28,8 @@ module.exports = [
var photo = data.photo_url
, parts = photo && photo.match(/media\/([^\/]+)/)
, id = parts && parts[1];

data.embed_src = id
? ('//giphy.com/embed/' + id)
? ('https://giphy.com/embed/' + id)
: null;

// NOTE: For some reason the embed width & height they are providing