Bye bye hash rockets and overflow newlines.

Rakefile

@@ -6,10 +6,10 @@ require 'spree/testing_support/common_rake'
 
 RSpec::Core::RakeTask.new
 
-task :default => [:spec]
+task default: :spec
 
 desc 'Generates a dummy app for testing'
 task :test_app do
   ENV['LIB_NAME'] = 'spree_reviews'
   Rake::Task['common:test_app'].invoke 'Spree::User'
-end
+end

app/controllers/spree/admin/feedback_reviews_controller.rb

@@ -1,5 +1,6 @@
 class Spree::Admin::FeedbackReviewsController <  Spree::Admin::ResourceController
   belongs_to 'spree/review'
+
   def index
     @collection = parent.feedback_reviews
   end

app/controllers/spree/admin/reviews_controller.rb

@@ -7,7 +7,6 @@ def index
 
   def approve
     r = Spree::Review.find(params[:id])
-
     if r.update_attribute(:approved, true)
        flash[:notice] = Spree.t("info_approve_review")
     else
@@ -27,7 +26,6 @@ def edit
 
   def collection
     params[:q] ||= {}
-
     @search = Spree::Review.ransack(params[:q])
     @collection = @search.result.includes([:product, :user, :feedback_reviews]).page(params[:page]).per(params[:per_page])
   end

app/controllers/spree/feedback_reviews_controller.rb

@@ -5,7 +5,6 @@ class Spree::FeedbackReviewsController < Spree::StoreController
   before_filter :load_review, only: [:create]
 
   def create
-
     if @review.present?
       @feedback_review = @review.feedback_reviews.new(feedback_review_params)
       @feedback_review.user = spree_current_user
@@ -16,12 +15,12 @@ def create
 
     respond_to do |format|
       format.html { redirect_to :back  }
-      format.js   { render :action => :create }
+      format.js   { render action: :create }
     end
-
   end
 
   protected
+
     def load_review
       @review ||= Spree::Review.find_by_id!(params[:review_id])
     end
@@ -38,4 +37,3 @@ def sanitize_rating
       params[:feedback_review][:rating].to_s.sub!(/\s*[^0-9]*\z/,'') unless (params[:feedback_review] && params[:feedback_review][:rating].blank?)
     end
 end
-

app/controllers/spree/reviews_controller.rb

@@ -1,14 +1,14 @@
 class Spree::ReviewsController < Spree::StoreController
   helper Spree::BaseHelper
-  before_filter :load_product, :only => [:index, :new, :create]
-  rescue_from ActiveRecord::RecordNotFound, :with => :render_404
+  before_filter :load_product, only: [:index, :new, :create]
+  rescue_from ActiveRecord::RecordNotFound, with: :render_404
 
   def index
     @approved_reviews = Spree::Review.approved.where(product: @product)
   end
 
   def new
-    @review = Spree::Review.new(:product => @product)
+    @review = Spree::Review.new(product: @product)
     authorize! :create, @review
   end
 
@@ -44,5 +44,4 @@ def permitted_review_attributes
   def review_params
     params.require(:review).permit(permitted_review_attributes)
   end
-
 end

app/helpers/spree/reviews_helper.rb

@@ -1,17 +1,15 @@
 module Spree::ReviewsHelper
-
   def star(the_class)
-    content_tag(:span, " ✮ ".html_safe, :class => the_class)
+    content_tag(:span, " ✮ ".html_safe, class: the_class)
   end
 
   def mk_stars(m)
     (1..5).collect {|n| n <= m ? star("lit") : star("unlit") }.join
   end
 
   def txt_stars(n, show_out_of = true)
-    res = Spree.t('star', :count => n)
+    res = Spree.t('star', count: n)
     res += " #{Spree.t('out_of_5')}" if show_out_of
     res
   end
-
 end

app/models/spree/feedback_review.rb

@@ -1,17 +1,14 @@
 class Spree::FeedbackReview < ActiveRecord::Base
-  belongs_to :user, :class_name => Spree.user_class.to_s
-
+  belongs_to :user, class_name: Spree.user_class.to_s
   belongs_to :review, dependent: :destroy
-  validates :review, presence: true
 
+  validates :review, presence: true
   validates :rating, numericality: { only_integer: true,
-                                     greater_than_or_equal_to: 1, 
+                                     greater_than_or_equal_to: 1,
                                      less_than_or_equal_to: 5,
                                      message: Spree.t('you_must_enter_value_for_rating') }
 
   scope :most_recent_first, -> { order("spree_feedback_reviews.created_at DESC") }
   default_scope { most_recent_first }
-
   scope :localized, lambda { |lc| where('spree_feedback_reviews.locale = ?', lc) }
-
 end

app/models/spree/product_decorator.rb

@@ -8,7 +8,6 @@ def stars
 
   def recalculate_rating
     reviews_count = self.reviews.reload.approved.count
-
     self.reviews_count = reviews_count
     if reviews_count > 0
       self.avg_rating = self.reviews.approved.sum(:rating).to_f / reviews_count
@@ -17,5 +16,4 @@ def recalculate_rating
     end
     self.save
   end
-
 end

app/models/spree/review.rb

@@ -1,22 +1,21 @@
 class Spree::Review < ActiveRecord::Base
   belongs_to :product, touch: true
-  belongs_to :user, :class_name => Spree.user_class.to_s
+  belongs_to :user, class_name: Spree.user_class.to_s
   has_many   :feedback_reviews
 
-  after_save :recalculate_product_rating, :if => :approved?
+  after_save :recalculate_product_rating, if: :approved?
   after_destroy :recalculate_product_rating
 
   validates :name, presence: true
   validates :review, presence: true
-
   validates :rating, numericality: { only_integer: true,
-                                     greater_than_or_equal_to: 1, 
+                                     greater_than_or_equal_to: 1,
                                      less_than_or_equal_to: 5,
                                      message: Spree.t('you_must_enter_value_for_rating') }
 
 
   default_scope { order("spree_reviews.created_at DESC") }
-  
+
   scope :localized, ->(lc) { where('spree_reviews.locale = ?', lc) }
   scope :most_recent_first, -> { order('spree_reviews.created_at DESC') }
   scope :oldest_first, -> { reorder('spree_reviews.created_at ASC') }

app/models/spree/reviews_configuration.rb

@@ -4,23 +4,23 @@ def self.boolean_preferences
   end
 
   # include non-approved reviews in (public) listings
-  preference :include_unapproved_reviews, :boolean, :default => false
+  preference :include_unapproved_reviews, :boolean, default: false
 
   # control how many reviews are shown in summaries etc.
-  preference :preview_size, :integer, :default => 3
+  preference :preview_size, :integer, default: 3
 
   # show a reviewer's email address
-  preference :show_email, :boolean, :default => false
+  preference :show_email, :boolean, default: false
 
   # show helpfullness rating form elements
-  preference :feedback_rating, :boolean, :default => false
+  preference :feedback_rating, :boolean, default: false
 
   # require login to post reviews
-  preference :require_login, :boolean, :default => true
+  preference :require_login, :boolean, default: true
 
   # whether to keep track of the reviewer's locale
-  preference :track_locale, :boolean, :default => false
+  preference :track_locale, :boolean, default: false
 
   # render checkbox for a user to approve to show their identifier (name or email) on their review
-  preference :render_show_identifier_checkbox, :boolean, :default => false
+  preference :render_show_identifier_checkbox, :boolean, default: false
 end

app/overrides/add_reviews_after_product_properties.rb

@@ -1,5 +1,5 @@
-Deface::Override.new(:virtual_path => "spree/products/show",
-                     :name => "converted_product_properties_767643482",
-                     :insert_after => "[data-hook='product_properties']",
-                     :partial => "spree/shared/reviews",
-                     :disabled => false)
+Deface::Override.new(virtual_path: "spree/products/show",
+                     name: "converted_product_properties_767643482",
+                     insert_after: "[data-hook='product_properties']",
+                     partial: "spree/shared/reviews",
+                     disabled: false)

app/overrides/add_reviews_tab_to_admin.rb

@@ -1,4 +1,4 @@
-Deface::Override.new(:virtual_path => "spree/admin/shared/_product_sub_menu",
-                     :name => "reviews_admin_tab",
-                     :insert_bottom => "[data-hook='admin_product_sub_tabs']",
-                     :text => "<%= tab(:reviews, :label => 'review_management') %>")
+Deface::Override.new(virtual_path: "spree/admin/shared/_product_sub_menu",
+                     name: "reviews_admin_tab",
+                     insert_bottom: "[data-hook='admin_product_sub_tabs']",
+                     text: "<%= tab(:reviews, label: 'review_management') %>")

app/overrides/add_reviews_to_admin_configuration_sidebar.rb

@@ -1,5 +1,5 @@
-Deface::Override.new(:virtual_path => "spree/admin/shared/_configuration_menu",
-                     :name => "converted_admin_configurations_menu",
-                     :insert_bottom => "[data-hook='admin_configurations_sidebar_menu'], #admin_configurations_sidebar_menu[data-hook]",
-                     :text => "<%= configurations_sidebar_menu_item Spree.t('spree_reviews.review_settings'), edit_admin_review_settings_path %>",
-                     :disabled => false)
+Deface::Override.new(virtual_path: "spree/admin/shared/_configuration_menu",
+                     name: "converted_admin_configurations_menu",
+                     insert_bottom: "[data-hook='admin_configurations_sidebar_menu'], #admin_configurations_sidebar_menu[data-hook]",
+                     text: "<%= configurations_sidebar_menu_item Spree.t('spree_reviews.review_settings'), edit_admin_review_settings_path %>",
+                     disabled: false)

app/views/spree/admin/feedback_reviews/index.html.erb

@@ -1,9 +1,9 @@
 <% content_for :page_title do %>
-	<%= Spree.t('feedback_review_for', :review => @review.title) %>
+	<%= Spree.t('feedback_review_for', review: @review.title) %>
 <% end %>
 
 <% content_for :page_actions do %>
-	<li><%= button_link_to Spree.t(:back_to_reviews), admin_reviews_path, { :icon => 'icon-arrow-left' } %></li>
+	<li><%= button_link_to Spree.t(:back_to_reviews), admin_reviews_path, { icon: 'icon-arrow-left' } %></li>
 <% end %>
 
 <% render 'spree/admin/shared/product_sub_menu' %>
@@ -31,7 +31,7 @@
 			  <td><%= feedback.rating %></td>
 			  <td><%= l feedback.created_at %></td>
 			  <td class="actions">
-				  <%= link_to_delete feedback, :no_text => true  %>
+				  <%= link_to_delete feedback, no_text: true  %>
 			  </td>
 			</tr>
 		<% end %>

app/views/spree/admin/review_settings/edit.html.erb

@@ -4,7 +4,7 @@
 	<%= Spree.t("spree_reviews.review_settings") %>
 <% end %>
 
-<%= form_tag(admin_review_settings_path, :method => :put) do %>
+<%= form_tag(admin_review_settings_path, method: :put) do %>
 	<fieldset class="no-border-top">
 		<div class="field">
 			<%= check_box_tag('preferences[include_unapproved_reviews]', "1", Spree::Reviews::Config[:include_unapproved_reviews]) %>
@@ -28,13 +28,13 @@
 		</div>
 		<div class="field">
 			<label><%= Spree.t('spree_reviews.preview_size') %></label><br>
-			<%= text_field_tag('preferences[preview_size]', Spree::Reviews::Config[:preview_size], :size => 3) %>
+			<%= text_field_tag('preferences[preview_size]', Spree::Reviews::Config[:preview_size], size: 3) %>
 		</div>
 
 		<div class="form-buttons filter-actions actions" data-hook="buttons">
 			<%= button Spree.t('actions.update'), 'icon-refresh' %>
 			<span class="or"><%= Spree.t(:or) %></span>
-			<%= link_to_with_icon 'icon-remove', Spree.t('actions.cancel'), edit_admin_general_settings_url, :class => 'button' %>
+			<%= link_to_with_icon 'icon-remove', Spree.t('actions.cancel'), edit_admin_general_settings_url, class: 'button' %>
 		</div>
 	</fieldset>
 <% end %>

app/views/spree/admin/reviews/_form.html.erb

@@ -1,22 +1,22 @@
-<%= render "spree/shared/error_messages", :target => @review %>
+<%= render "spree/shared/error_messages", target: @review %>
 <%= f.field_container :name do %>
   <%= f.label :name %><br />
-  <%= f.text_field :name, :maxlength => "255", :size => "60" %>
+  <%= f.text_field :name, maxlength: "255", size: "60" %>
 <% end %>
 
 <%= f.field_container :title do %>
   <%= f.label :title %><br />
-  <%= f.text_field :title, :maxlength => "255", :size => "60" %>
+  <%= f.text_field :title, maxlength: "255", size: "60" %>
 <% end %>
 
 <%= f.field_container :review do %>
   <%= f.label :review %><br />
-  <%= f.text_area :review, :wrap => "virtual", :rows => "10", :cols => "60" %>
+  <%= f.text_area :review, wrap: "virtual", rows: "10", cols: "60" %>
 <% end %>
 
 <% if Spree::Reviews::Config[:track_locale] %>
 <%= f.field_container :locale do %>
   <%= f.label :locale %><br />
-  <%= f.select :locale, I18n.available_locales.map { |lc| [t(lc, :default => lc.to_s), lc.to_s] } %>
+  <%= f.select :locale, I18n.available_locales.map { |lc| [t(lc, default: lc.to_s), lc.to_s] } %>
 <% end %>
 <% end %>

app/views/spree/admin/reviews/edit.html.erb

@@ -1,5 +1,5 @@
 <% content_for :page_title do %>
-	<%= Spree.t(:editing_review_for_html, :link => link_to(@review.product.name, product_path(@review.product))) %>
+	<%= Spree.t(:editing_review_for_html, link: link_to(@review.product.name, product_path(@review.product))) %>
 <% end %>
 
 <% render 'spree/admin/shared/product_sub_menu' %>
@@ -15,7 +15,7 @@
 	</div>
 
 	<div class="omega eight columns">
-		<%= render 'form', :f => f %>
+		<%= render 'form', f: f %>
 	</div>
 
 	<div class="clear"></div>

app/views/spree/admin/reviews/index.html.erb

@@ -15,21 +15,21 @@
 		<div class="alpha three columns">
 			<div class="field">
 				<%= label_tag nil, Spree.t(:user) %><br />
-				<%= f.text_field :name_cont, :size => 25 %>
+				<%= f.text_field :name_cont, size: 25 %>
 			</div>
 		</div>
 
 		<div class="seven columns">
 			<div class="field">
 				<%= label_tag nil, Spree.t(:title) -%><br/>
-				<%= f.text_field :title_cont, :size => 25  -%>
+				<%= f.text_field :title_cont, size: 25  -%>
 			</div>
 		</div>
 
 		<div class="four columns">
 			<div class="field">
 				<%= label_tag nil, Spree.t(:review) -%><br/>
-				<%= f.text_field :review_cont, :size => 25  -%>
+				<%= f.text_field :review_cont, size: 25  -%>
 			</div>
 		</div>
 
@@ -89,14 +89,14 @@
 					<p><%= Spree::Review.human_attribute_name(:ip_address) %>: <%= review.ip_address ? link_to(review.ip_address, "http://whois.domaintools.com/#{review.ip_address}") : '-' %></p>
 				</td>
 				<td class="align-center">
-					<%= l review.created_at, :format => :short %>
+					<%= l review.created_at, format: :short %>
 				</td>
 				<td class="actions">
-					<%= link_to_with_icon 'check', Spree.t('approve'), approve_admin_review_url(review), :no_text => true, class: 'approve' unless review.approved %>
+					<%= link_to_with_icon 'check', Spree.t('approve'), approve_admin_review_url(review), no_text: true, class: 'approve' unless review.approved %>
 					&nbsp;
-					<%= link_to_edit review, :no_text => true, :class => 'edit' %>
+					<%= link_to_edit review, no_text: true, class: 'edit' %>
 					&nbsp;
-					<%= link_to_delete review, :no_text => true %>
+					<%= link_to_delete review, no_text: true %>
 				</td>
 			</tr>
 		<% end %>

app/views/spree/feedback_reviews/_form.html.erb

@@ -1,13 +1,13 @@
-<%= render 'spree/feedback_reviews/summary', :review => review %>
-<%= form_for((@feedback_review ||= review.feedback_reviews.build), :url => feedback_reviews_path(review), :method => :post, :remote => true) do |f| %>
+<%= render 'spree/feedback_reviews/summary', review: review %>
+<%= form_for((@feedback_review ||= review.feedback_reviews.build), url: feedback_reviews_path(review), method: :post, remote: true) do |f| %>
 <% unless @feedback_review.errors.empty? %>
  <span class="error"><%= @feedback_review.errors[:rating] %></span>
  <br />
 <% end %>
 <%= Spree.t(:was_this_review_helpful) %>
 <% for i in 1..NB_STARS %>
   <%= radio_button_tag "feedback_review[rating]",
-                       Spree.t('star', :count => i), false, :class => "star" %>
+                       Spree.t('star', count: i), false, class: "star" %>
 <% end %>
 <button class="feedback-review"><span><%= Spree.t(:say_yes) %></span></button>
 <% end %>

app/views/spree/feedback_reviews/_summary.html.erb

@@ -1,6 +1,6 @@
 <p>
-  <%= Spree.t('voice', :count => review.feedback_reviews.count) %>.
+  <%= Spree.t('voice', count: review.feedback_reviews.count) %>.
   <span title="<%= pluralize(review.feedback_stars, 'star') %> <%= Spree.t('out_of_5') %>">
-  <%= render 'spree/reviews/stars', :stars => review.feedback_stars %>
+  <%= render 'spree/reviews/stars', stars: review.feedback_stars %>
   </span> &nbsp;
 </p>