Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webapp): migrate from @mdi/font to @mdi/js #867

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Jan 9, 2024

Final migration. Mdi webfont not used anymore.

Change

Use tree shakeable version instead of big webfont.

Reference

Closes #710

www/webapp/src/views/ResetPassword.vue Outdated Show resolved Hide resolved
www/webapp/src/assets/global.css Outdated Show resolved Hide resolved
Use tree shakeable version instead of big webfont.
Copy link
Member

@peterthomassen peterthomassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thank you very much <3

@peterthomassen peterthomassen merged commit 82814f8 into desec-io:main Jan 11, 2024
5 checks passed
@Rotzbua Rotzbua deleted the feat_migrate_mdi branch January 11, 2024 10:04
@peterthomassen
Copy link
Member

This has saved about 20% of bytes transmitted when loading the webapp. Very cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace icon font @mdi/font
2 participants