chore(webapp): migrate to vite 5 #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #805 |
Rotzbua
force-pushed
the
chore_migrate_vite_5
branch
from
677e22c
to
3b79ecc
Compare
Rotzbua
force-pushed
the
chore_migrate_vite_5
branch
from
8167ce7
to
0609632
Compare
Rotzbua
force-pushed
the
chore_migrate_vite_5
branch
from
0609632
to
cdfff57
Compare
|
@peterthomassen Works for me. Can you review? Happy xmas 🎄 |
peterthomassen
requested changes
Jan 2, 2024
There was a problem hiding this comment.
Thanks! Looks mostly good; just minor stuff.
According to https://vitejs.dev/guide/migration#allow-path-containing-to-fallback-to-index-html, this also fixes #805. Can you confirm that's the case?
Same to you, very much belated! And happy new year! 🥳 |
Rotzbua
force-pushed
the
chore_migrate_vite_5
branch
from
cdfff57
to
56db3ac
Compare
Because old `vuetify` is used. `sass` can be bumped if whole webapp is migrated to vue@v3 and according vuetify.
Hash updated with new release v5.2 of `@vitejs/plugin-legacy`.
peterthomassen
force-pushed
the
chore_migrate_vite_5
branch
from
56db3ac
to
8ce07b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guide
https://vitejs.dev/guide/migration.html
Changes