Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webapp): missing import extension .vue #773

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Jul 22, 2023

Extension is required for imports with vite.

Seems currently not mandatory maybe caused by the vue2-vite-plugin.

Changes

  • Add eslint rule to ensure the extension.
  • Add extension where necessary.

Reference

Confirmed by vitejs/vite#178 (comment) .
Part of the migration #771

Copy link
Member

@peterthomassen peterthomassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@peterthomassen peterthomassen merged commit 43f1cee into desec-io:main Aug 2, 2023
4 checks passed
@Rotzbua Rotzbua deleted the fix_import branch August 15, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants