Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webapp): Fix component file name #763

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Jul 15, 2023

Note

vite has a problem with A.vue which is compiled as <a> . Not sure why...
Renaming to RecordA.vue fixes this problem.

Questions

  • keep folder Record or replace by shorter r?

@Rotzbua Rotzbua force-pushed the fix_component_file_name branch 4 times, most recently from 180e56e to f9f2bd7 Compare July 17, 2023 23:33
@Rotzbua Rotzbua marked this pull request as ready for review July 17, 2023 23:56
@peterthomassen
Copy link
Member

vite has a problem with A.vue which is compiled as <a> . Not sure why... Renaming to RecordA.vue fixes this problem.

Maybe it's worth inquiring?

@Rotzbua
Copy link
Contributor Author

Rotzbua commented Jul 20, 2023

To be honest, I found it more useful to spend time on migration than on finding the cause.

@peterthomassen
Copy link
Member

Sure. - Let's get rid of the Record folder then, and we can go ahead.

Copy link
Member

@peterthomassen peterthomassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above

Copy link
Member

@peterthomassen peterthomassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@peterthomassen peterthomassen merged commit 6d2590c into desec-io:main Aug 2, 2023
4 checks passed
@Rotzbua Rotzbua deleted the fix_component_file_name branch August 8, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants