Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a possibility to show and set address of the Display #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rodrigosiviero
Copy link

I added some functions because I feel that lacks for new users to being able to find the display addresses, if it's not good enough maybe it help someone, great project guys, really great cannot wait for rest API so I can Integrate with Home Assistant!

  • Refactored some minor syntaxes for Github Markdown
  • Removed some unnecessary comments #
  • Added the ability to show the IDM Name and Address
  • Added the ability to set a file with the current Address of the Display, every time that app.py is called it will check if the file is there, if it is there's no need for address flag
    Usage:
./run_in_venv.sh --device-address show
./run_in_venv.sh --device-address set

@derkalle4
Copy link
Owner

Hi @rodrigosiviero

many thanks for your pull request. I see you have changed many other things as well (I bet automatically due to some formatting tool within your IDE). Maybe we should agree on one standard to make it look the same for everyone.

However, thanks for your work! This would help with #17

Anyway, I will need to look further into it because I don't know which ways we should support to set the address (yet). I am planning on supporting multiple devices as well and use yaml for this. Unfortunately I haven't got the time to implement this as well. But then it would include some kind of configuration file which the app.py could read upon startup.

Will report back later when I got more time to look into your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants