WIP #87
Open
WIP #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -364,7 +365,9 @@ Subscription will be done only once within first request to backend server. | |||
|
|
|||
| sub wait_for_messages { | |||
| my ($self) = @_; | |||
| $self->{already_waiting} //= $self->redis->subscribe([$self->whoami], $self->redis->curry::weak::on(message => $self->curry::weak::_on_message)); | |||
| $self->{already_waiting} //= | |||
| $self->redis->subscribe(['myriad.' . $self->whoami, $self->whoami], | |||
There was a problem hiding this comment.
Is it possible to only add the prefix based on msg_group so we can subscribe to a single channel?
There was a problem hiding this comment.
Yes, we can also pass the prefix from our API and prepend it to $self->whoami.
| @@ -364,7 +365,9 @@ Subscription will be done only once within first request to backend server. | |||
|
|
|||
| sub wait_for_messages { | |||
| my ($self) = @_; | |||
| $self->{already_waiting} //= $self->redis->subscribe([$self->whoami], $self->redis->curry::weak::on(message => $self->curry::weak::_on_message)); | |||
| $self->{already_waiting} //= | |||
| $self->redis->subscribe(['myriad.' . $self->whoami, $self->whoami], | |||
There was a problem hiding this comment.
Let's not add myriad hardcoded in proxy, it's an open source module. Pass it as a config or as a parameter
There was a problem hiding this comment.
We can pass it from websocket.conf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.