-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suisin/sign up country code dropdown #18058
Open
suisin-deriv
wants to merge
8
commits into
deriv-com:master
Choose a base branch
from
suisin-deriv:suisin/sign_up_country_code_dropdown
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Suisin/sign up country code dropdown #18058
suisin-deriv
wants to merge
8
commits into
deriv-com:master
from
suisin-deriv:suisin/sign_up_country_code_dropdown
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ce2e51d
to
5d60713
Compare
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
⏳ Generating Lighthouse report... |
8e8826f
to
ba66af4
Compare
ba66af4
to
c119d3e
Compare
likhith-deriv
approved these changes
Feb 14, 2025
shahzaib-deriv
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR is to implement country code dropdown behind a feature flag for real account sign up
Screenshots:
CR
![Screenshot 2024-12-05 at 11 14 35 AM](https://private-user-images.githubusercontent.com/103026762/392671658-120a68b9-15e3-4c3f-aadb-4da0c533dce4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MzE5MDYsIm5iZiI6MTczOTUzMTYwNiwicGF0aCI6Ii8xMDMwMjY3NjIvMzkyNjcxNjU4LTEyMGE2OGI5LTE1ZTMtNGMzZi1hYWRiLTRkYTBjNTMzZGNlNC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQxMTEzMjZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wYmIzNzYyMGE5NGU2ZGZjNzhhOGQ2NjJmMmZmNTJkOTA4YTYwZDcxZTQxYzI5NGM1ZTZlOTA5YzUzMzEyMGUyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.OUb-AaeyXOhY642AodTeoCniztAQuu9ya3_g0HsZumE)
![Screenshot 2024-12-05 at 11 19 01 AM](https://private-user-images.githubusercontent.com/103026762/392671669-48c83c53-6e38-4aef-8cac-07d347297231.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MzE5MDYsIm5iZiI6MTczOTUzMTYwNiwicGF0aCI6Ii8xMDMwMjY3NjIvMzkyNjcxNjY5LTQ4YzgzYzUzLTZlMzgtNGFlZi04Y2FjLTA3ZDM0NzI5NzIzMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQxMTEzMjZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hYmZiZDI4N2YyMmI5M2MxZDdhMTA5ZTU3N2I5OWFmMjdjNTkzZmRmZDRiMjc5YWFhYTAyNzI5YTAwZWQxMmE0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.h58eHG3mxAORDxTrqi9Eq3Z2QeRjcCpQ-W6lX2EhVds)
EU