spdk: validate nodes running instance manager pod rather than all nodes

[derekbit]

Longhorn 5739

Summary by CodeRabbit

• New Features

  • Enhanced SPDK validation by integrating checks for instance managers to ensure sufficient hugepage capacity.
  • Improved volume management by refining checks to confirm all volumes are detached before operations.

• Bug Fixes

  • Updated error handling and logging for better clarity when retrieving Kubernetes nodes and validating their states.

[coderabbitai]

Walkthrough

The changes in the datastore/longhorn.go file involve significant updates to the ValidateSpdk and AreAllVolumesDetached methods. The ValidateSpdk method now checks for hugepages-2Mi capacity across instance managers instead of Kubernetes nodes, enhancing the validation process for SPDK. The AreAllVolumesDetached method has also been updated to include instance manager checks, refining the logic for volume state verification. Additionally, the changes include updates to error handling and logging, maintaining the overall method structure while improving functionality related to SPDK validation and volume management.

Changes

File	Change Summary
datastore/longhorn.go	- Updated ValidateSpdk to check hugepages-2Mi capacity across instance managers.
	- Modified AreAllVolumesDetached to include instance manager checks for volume attachment state.
	- Enhanced error handling and logging related to Kubernetes nodes and validation states.
	- Updated method signatures for ValidateSpdk, AreAllVolumesDetached, ListInstanceManagersBySelector, and ListInstanceManagers.

Poem

🐰 In the datastore where volumes play,
Instance managers lead the way.
Hugepages checked with care and grace,
SPDK's ready, it's time to race!
With logs that sing and errors that flee,
A hop of joy for you and me! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e735af0 and a301d9f.

📒 Files selected for processing (1)

• datastore/longhorn.go (1 hunks)

🧰 Additional context used

🔇 Additional comments (1)

datastore/longhorn.go (1)

403-410: ⚠️ Potential issue

Potential oversight in validating nodes without instance managers

By iterating only over instance managers to validate hugepages-2Mi capacity, the code may miss nodes that do not currently have instance managers but could in the future. This could lead to enabling SPDK on nodes without sufficient hugepages-2Mi capacity when new instance managers are scheduled.

Consider modifying the validation to include all nodes that could potentially run instance managers to ensure cluster-wide safety when enabling SPDK.

Run the following script to identify nodes without instance managers and check their hugepages-2Mi capacity:

[github-actions]

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.