Initialize backingimage and backingimagedatasource sourceType

Fix upgrade failure from v1.1.x to master-head. The sourceType of backingimage and backingimagedatasource in v1.1.x is "", so initialize it in the mutating webhook. Signed-off-by: Derek Su <[email protected]>
derekbit · Feb 12, 2022 · d885794 · d885794
1 parent 256a780
commit d885794
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/webhook/resources/backingimage/mutator.go b/webhook/resources/backingimage/mutator.go
@@ -1,6 +1,8 @@
 package backingimage
 
 import (
+	"fmt"
+
 	admissionregv1 "k8s.io/api/admissionregistration/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 
@@ -45,6 +47,10 @@ func mutateBackingImage(newObj runtime.Object) (admission.PatchOps, error) {
 
 	backingImage := newObj.(*longhorn.BackingImage)
 
+	if backingImage.Spec.SourceType == "" {
+		patchOps = append(patchOps, fmt.Sprintf(`{"op": "replace", "path": "/spec/sourceType", "value": "%s"}`, longhorn.BackingImageDataSourceTypeDownload))
+	}
+
 	if backingImage.Spec.Disks == nil {
 		patchOps = append(patchOps, `{"op": "replace", "path": "/spec/disks", "value": {}}`)
 	}

diff --git a/webhook/resources/backingimagedatasource/mutator.go b/webhook/resources/backingimagedatasource/mutator.go
@@ -1,6 +1,8 @@
 package backingimagedatasource
 
 import (
+	"fmt"
+
 	admissionregv1 "k8s.io/api/admissionregistration/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 
@@ -45,6 +47,10 @@ func mutateBackingImageDatasource(newObj runtime.Object) (admission.PatchOps, er
 
 	backingimagedatasource := newObj.(*longhorn.BackingImageDataSource)
 
+	if backingimagedatasource.Spec.SourceType == "" {
+		patchOps = append(patchOps, fmt.Sprintf(`{"op": "replace", "path": "/spec/sourceType", "value": "%s"}`, longhorn.BackingImageDataSourceTypeDownload))
+	}
+
 	if backingimagedatasource.Spec.Parameters == nil {
 		patchOps = append(patchOps, `{"op": "replace", "path": "/spec/parameters", "value": {}}`)
 	}