Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds configurable custom columns to table view #915

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alepar
Copy link

@alepar alepar commented Oct 27, 2020

This is my shot at #755. It is mostly complete, just need to go through the rest of renderable types (PodWithMetrics,...) and make it implement RenderableRaw where possible. And make all of the parameters of HeaderColumn configurable via the settings file. Oh, and add it to the docs!
I'll finish that if the rest of the approach here is fine.

Some notable points:

  • Configuration for this is currently in a separate file. I've considered putting it in views.yml instead (or another single file, where one could configure both view and model at the same time), but decided against it. Good argument can be made for both approaches, so I'd be happy to talk about it.
  • I lack the knowledge to figure out how to test the GenericRenderer code path. The most questionable part is here. Would appreciate any pointers (essentially, which views use the code path). Will look around more.
  • I don't think there's currently a way to sort a table on a custom column. But it is likely something that people will want.

Happy to discuss any other points.

@derailed
Copy link
Owner

@alepar Thank you for submitting this great PR! I haven't forgotten and generally like your approach here. I need to find the time to review and noodle on this feature. I think we should keep the column defs with the views imho to make this feature easier to manage.

@derailed derailed added the enhancement New feature or request label Dec 10, 2020
@superbrothers
Copy link

I would like this feature. What is the status of this PR?

@Xyaren
Copy link

Xyaren commented Jul 20, 2021

Is this still being worked on ?
I would really appreciate this feature.

@Champ-Goblem
Copy link

I would also be interested in this feature being added

@fragolinux
Copy link
Contributor

very interested in this feature!

@cimlite
Copy link

cimlite commented Sep 22, 2022

I also think this is a great feature. Are there any news on it?
Is it possible to try it out in its current state, by cloning the repo and building it? Any additional configuration needed in that case?

Thanks!

@guanchzhou
Copy link
Contributor

Looks like custom columns have been delivered in #3109.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants