case sensitive for specific command args and flags #2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe not the best solution, what do you think would be a better way to fix it? |
derailed
approved these changes
Dec 26, 2023
There was a problem hiding this comment.
@wjiec Thank you Jayson for this fix! I think tho less than ideal for this one use case, this is ok as it should be the responsibility of args parser to figure out casing.
The main thing here is to ensure the cmd gets lowered as well as anything else beside context names which you've covered here.
Merged
thejoeejoee
pushed a commit
to thejoeejoee/k9s
that referenced
this pull request
Feb 23, 2024
placintaalexandru
pushed a commit
to placintaalexandru/k9s
that referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes #2389.