Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get node filtering params from matching context values #2375

Merged
merged 1 commit into from
Dec 25, 2023
Merged

get node filtering params from matching context values #2375

merged 1 commit into from
Dec 25, 2023

Conversation

wjiec
Copy link
Contributor

@wjiec wjiec commented Dec 25, 2023

this PR fixes #2370. see

k9s/internal/view/helpers.go

Lines 133 to 138 in defad7a

func podCtx(app *App, path, fieldSel string) ContextFunc {
return func(ctx context.Context) context.Context {
ctx = context.WithValue(ctx, internal.KeyPath, path)
return context.WithValue(ctx, internal.KeyFields, fieldSel)
}
}

derailed
derailed approved these changes Dec 25, 2023
View reviewed changes
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wjiec Excellent! Thank you once again Jayson for this quick fix!!

@derailed derailed merged commit e113f4b into derailed:master Dec 25, 2023
@wjiec wjiec deleted the bugfix/node-filter branch December 25, 2023 05:49
@wjiec
Copy link
Contributor Author

wjiec commented Dec 25, 2023

Haha, Merry Christmas 🎉

@derailed derailed mentioned this pull request Dec 25, 2023
Merged
@derailed
Copy link
Owner

lol - the gift that keeps on giving ;(
Merry Christmas Jayson!!

thejoeejoee pushed a commit to thejoeejoee/k9s that referenced this pull request Feb 23, 2024
@wjiec @thejoeejoee
get node filtering params from matching context values (derailed#2375)
9e432ed
placintaalexandru pushed a commit to placintaalexandru/k9s that referenced this pull request Apr 3, 2024
@wjiec
get node filtering params from matching context values (derailed#2375)
6e48481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong list of pods on node (0.30.X)
2 participants
@wjiec @derailed