-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pod status contstants to account for Evicted and ContainerStatusUnknown and leverage them in sanitize #2314
Conversation
@j2udev Thank you for you kind words Joshua! |
We do use PriorityClasses, but not heavily. Unfortunately (fortunately?), our cluster has been healthy since then and it's not overly easy to test getting it back into that state... nor do I think my colleagues would appreciate me intentionally trying to put the cluster into that state 😅. If I see it pop up again though, I can grab the debug logs. |
Lol - Right don't break your cluster on my account. Nw - will keep this in the pipe. |
@j2udev need TLC |
0cbfaec
to
777394b
Compare
Sorry about that got busy with my day job |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@j2udev Thanks for the updates Joshua!
Co-authored-by: Joshua Ward <[email protected]>
Co-authored-by: Joshua Ward <[email protected]>
I had a cluster that was blowing up with pods that were being Evicted and others that had ContainerStatusUnknown... figured I would try the new sanitize function, but noticed that it wasn't clearing them out. Updated accordingly.
I did notice some weird behavior in that the sanitize function didn't completely clear out everything in one run... (I had roughly 800-1000 failing pods 😱). I had to run it about 3 times to fully get everything. Is that expected?
I've said it before, but this tool is such a game changer. Thanks very much for all the hard work!