1.5.0 (#3)

* New: `--include-images` to check for broken images

CHANGELOG.md

@@ -1,6 +1,11 @@
 # octopus / CHANGELOG
 
 
+### 1.5.0 (2019-05-09)
+
+* New: `--include-images` to check for broken images
+
+
 ### 1.4.0 (2019-01-14)
 
 * Replace: Namespace `superreal` by `deptagency`

README.md

@@ -35,6 +35,7 @@ Option | Description | Default
 `--ignore-query` | Ignore a query string | `false`
 `--ignore-external` | Ignore all external links | `false`
 `--ignore-nofollow` | Ignore `rel=nofollow` links | `false`
+`--include-images` | Check `<img>` elements | `false`
 `--slack-webhook` | Slack incoming webhook url | `none`
 `--timeout` | Time to wait for response | `5000`
 `--silent` | Run without printing progress line | `false`

TODO.md

@@ -1,3 +1,3 @@
 - [x] Ignore rel="nofollow" links
 - [ ] Respect project config file
-- [ ] Images check 
+- [x] Images check 

lib/app.js

@@ -168,12 +168,26 @@ const request = async (requestUrl, referenceUrl, requestCallback) => {
             const $ = cheerioLoad(body);
 
             $('a[href]').not( ignoreProtocols.join(',') ).each( (i, elem) => {
-                const hrefUrl = new URL(elem.attribs.href, baseUrl).href;
+                if (elem.attribs.href) {
+                    const hrefUrl = new URL(elem.attribs.href, baseUrl).href;
 
-                if ( ! pageLinks.includes(hrefUrl) ) {
-                    pageLinks.push(hrefUrl);
+                    if ( ! pageLinks.includes(hrefUrl) ) {
+                        pageLinks.push(hrefUrl);
+                    }
                 }
             });
+
+            if ( config['include-images'] ) {
+                $('img[src]').each((i, elem) => {
+                    if (elem.attribs.src) {
+                        const srcUrl = new URL(elem.attribs.src, baseUrl).href;
+
+                        if (!pageLinks.includes(srcUrl)) {
+                            pageLinks.push(srcUrl);
+                        }
+                    }
+                });
+            }
         }
 
         // Execute callback
@@ -284,6 +298,7 @@ module.exports = (argv) => {
         'silent': Boolean(argv['silent']),
         'ignore-query': (Array.isArray(argv['ignore-query']) ? argv['ignore-query'] : Array(argv['ignore-query'])),
         'ignore-external': Boolean(argv['ignore-external']),
+        'include-images': Boolean(argv['include-images']),
         'slack-webhook': String(argv['slack-webhook']),
     };
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@deptagency/octopus",
-  "version": "1.4.0",
+  "version": "1.5.0",
   "main": "index.js",
   "license": "MIT",
   "description": "Recursive and multi-threaded broken link checker",

test/test.js

@@ -98,4 +98,22 @@ describe( 'Octopus Playground', () => {
 
     } );
 
+    it( `octopus ${playgroundUrl} --silent --include-images`, done => {
+
+        exec( `octopus ${playgroundUrl} --silent --include-images` ).then( result => {
+
+            const data = result.stdout.trim();
+
+            data.must.include( 'https://www.deptagency.com/wp-content/uploads/fly.jpeg' );
+            data.must.include( 'APPEARS ON: https://static-pages.sr-lab.de/kunden/public/github/octopus/' );
+            data.must.include( 'STATUS MSG: NOT FOUND (404)' );
+
+            data.must.include( '8 links checked' );
+
+            done();
+
+        } )
+
+    } );
+
 } );