Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacotor: faq 테스트 코드 작성 #340

Merged
merged 4 commits into from
Feb 18, 2024
Merged

refacotor: faq 테스트 코드 작성 #340

merged 4 commits into from
Feb 18, 2024

Conversation

kimyouknow
Copy link
Member

@kimyouknow kimyouknow commented Feb 18, 2024

작업 내용

#339 리뷰 반영 (aria 속성, 테스트 코드 수정) 안됐는데 일단 들어가고 이번주에 수정할게요,,,,,, 14기 끝나서 일단 들어감~~

스크린샷

사용 방법

레퍼런스

#335

* chore: vscode 기본 세팅

- explicit - Triggers Code Actions when explicitly saved. Same as true.
- https://code.visualstudio.com/updates/v1_85#_code-actions-on-save-and-auto

* chore: vitest 관련 라이브러리 설치

* chore: vitest 세팅

* feat: vitest Provider

* feat: formatSingleDigit vitest  잘 돌아가나 확인용 tc

* feat: vitest + react 잘 돌아가나 FAQ 컴포넌트  tc 작성
* feat: 테스트 케이스 추가

* feat: formatSingleDigit 선행조건 강화

* refactor: 음수 및 정수가 아닌 숫자 에러처리

* fix: infinity 관련 tc 추가
* refactor: 컴포넌트 aria-label 추가 및 시맨틱 태그 부여

* feat: faq 컴포넌트 테스트 코드 작성

* chore: 스토리북 props

* feat: [지원자격] 탭 활성 description 수정 및 테스트 세분화

* refactor: 답변이 보이는 질문 리스트 셀렉터 수정

* feat: 세부구현~
Copy link

vercel bot commented Feb 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
www-depromeet-com ✅ Ready (Inspect) Visit Preview Feb 18, 2024 3:00pm

Copy link

Bundle Sizes

Compared against none

Route Size (gzipped)
/ 85.34 KB
/404 72.3 KB
/_app 123.87 KB
/_error 71.83 KB
/about 76.55 KB
/apply 74 KB
/project 78.81 KB
/recruit 81.66 KB

Dynamic import: None found.

Copy link

@sumi-0011
Copy link
Member

수고하셨습니당

Copy link
Member

@sumi-0011 sumi-0011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kimyouknow kimyouknow merged commit 60e83ad into main Feb 18, 2024
12 of 13 checks passed
@kimyouknow kimyouknow deleted the base/faq-refactor branch February 18, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants