-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refacotor: faq 테스트 코드 작성 #340
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: vscode 기본 세팅 - explicit - Triggers Code Actions when explicitly saved. Same as true. - https://code.visualstudio.com/updates/v1_85#_code-actions-on-save-and-auto * chore: vitest 관련 라이브러리 설치 * chore: vitest 세팅 * feat: vitest Provider * feat: formatSingleDigit vitest 잘 돌아가나 확인용 tc * feat: vitest + react 잘 돌아가나 FAQ 컴포넌트 tc 작성
* feat: 테스트 케이스 추가 * feat: formatSingleDigit 선행조건 강화 * refactor: 음수 및 정수가 아닌 숫자 에러처리 * fix: infinity 관련 tc 추가
chore: faq - tc
* refactor: 컴포넌트 aria-label 추가 및 시맨틱 태그 부여 * feat: faq 컴포넌트 테스트 코드 작성 * chore: 스토리북 props * feat: [지원자격] 탭 활성 description 수정 및 테스트 세분화 * refactor: 답변이 보이는 질문 리스트 셀렉터 수정 * feat: 세부구현~
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle SizesCompared against none
Dynamic import: None found. |
수고하셨습니당 |
sumi-0011
approved these changes
Feb 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
#339 리뷰 반영 (aria 속성, 테스트 코드 수정) 안됐는데 일단 들어가고 이번주에 수정할게요,,,,,, 14기 끝나서 일단 들어감~~
스크린샷
사용 방법
레퍼런스
#335