Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] SQLiteService 구현 #14

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

[Feature] SQLiteService 구현 #14

wants to merge 1 commit into from

Conversation

sustainable-git
Copy link
Member

@sustainable-git sustainable-git commented Nov 19, 2022 •
edited
Loading

📌 배경

close #3

내용

  • Merge하지 말아주세요!
  • SQLiteService를 만들었습니다.
    • 내부 DB 필요시 사용, 참고 예정

@sustainable-git sustainable-git added the ⚡️Feature 새 기능 또는 구성 추가 label Nov 19, 2022
@sustainable-git sustainable-git self-assigned this Nov 19, 2022
@sustainable-git sustainable-git requested a review from a team as a code owner November 19, 2022 07:12
@sustainable-git sustainable-git requested review from Marcorable, joseph704 and kipsong133 and removed request for a team November 19, 2022 07:12
@junhaesung
Copy link
Member

안녕하세요-
옆옆팀이지만 코멘트 하나 남길게요.
PR 생성시 draft 로 만들면 '머지하지 말아주세요' 라는 의도를 나타낼 수 있을거같아요 :)

@sustainable-git
Copy link
Member Author

안녕하세요-
옆옆팀이지만 코멘트 하나 남길게요.
PR 생성시 draft 로 만들면 '머지하지 말아주세요' 라는 의도를 나타낼 수 있을거같아요 :)

오! 감사합니다 👍

@sustainable-git sustainable-git marked this pull request as draft November 26, 2022 15:20
@sustainable-git sustainable-git marked this pull request as ready for review November 26, 2022 15:21
@sustainable-git sustainable-git marked this pull request as draft November 26, 2022 15:21
kipsong133
kipsong133 approved these changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@kipsong133 kipsong133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQLLite 서버 개발 속도가 안맞거나 네트워킹 최적화할 때
바로 적용해보는걸로 하시죠!

@kipsong133 kipsong133 marked this pull request as ready for review December 12, 2022 10:45
@Marcorable Marcorable closed this Jan 12, 2023
@Marcorable Marcorable reopened this Jan 12, 2023
@sustainable-git sustainable-git marked this pull request as draft January 12, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kipsong133 kipsong133 kipsong133 approved these changes

@Marcorable Marcorable Awaiting requested review from Marcorable Marcorable is a code owner automatically assigned from depromeet/12th-team-6-ios

@joseph704 joseph704 Awaiting requested review from joseph704 joseph704 is a code owner automatically assigned from depromeet/12th-team-6-ios

Assignees

@sustainable-git sustainable-git

Labels
⚡️Feature 새 기능 또는 구성 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

내부 DB 구현
4 participants
@sustainable-git @junhaesung @kipsong133 @Marcorable