Refactor: method name #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yaminyam
reviewed
Jan 8, 2023
Comment on lines
11
to
16
| async findByContent(search: string) { | ||
| return await this.createQueryBuilder('article') | ||
| .where('article.title LIKE :search', { search }) | ||
| .where('article.content LIKE :search', { search }) | ||
| .getMany(); | ||
| } |
There was a problem hiding this comment.
byContent라고 하기에는 title이랑 content를 둘다 포함하고있어서 좀 애매하네요
There was a problem hiding this comment.
content 말고 keyword 그런거로도 바꿀 수 있을 것 같아요
There was a problem hiding this comment.
findByColumn 과 같은 이름으로 많이쓰니까 그거랑 아예 구분하기위해서
stae1102
approved these changes
Jan 8, 2023
stae1102
reviewed
Jan 8, 2023
| @@ -7,4 +7,11 @@ export class ArticleRepository extends Repository<Article> { | |||
| constructor(private readonly dataSource: DataSource) { | |||
| super(Article, dataSource.createEntityManager(), dataSource.createQueryRunner()); | |||
| } | |||
|
|
|||
| async search(search: string) { | |||
There was a problem hiding this comment.
다른 데는 타입 지정해놓으셔서 여기도 추가하면 좋을 듯 해서 코멘트 남깁니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
중요하진 않은 변경사항이기에
심사 후에 머지해도 상관 없습니다