Input, Label 공통 컴포넌트 개발 (+ 컨테이너, 훅) #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klmhyeonwoo
reviewed
Jul 14, 2024
src/component/common/Input/Label.tsx
Outdated
| styles?: Interpolation<Theme>; | ||
| } & React.LabelHTMLAttributes<HTMLLabelElement>; | ||
|
|
||
| export const Label = ({ id, children, order, styles }: LabelProps) => { |
sean2337
approved these changes
Jul 14, 2024
donghunee
reviewed
Jul 15, 2024
src/hooks/useInput.ts
Outdated
Comment on lines
3
to
11
| type UseInputReturn = [string, (e: React.ChangeEvent<HTMLInputElement>) => void]; | ||
|
|
||
| export const useInput = (defaultValue?: string): UseInputReturn => { | ||
| const [value, setValue] = useState(defaultValue || ""); | ||
|
|
||
| const handleInputChange = useCallback((e: React.ChangeEvent<HTMLInputElement>) => { | ||
| setValue(e.target.value); | ||
| }, []); | ||
|
|
||
| return [value, handleInputChange]; | ||
| }; |
There was a problem hiding this comment.
해당 부분도 as const로 return type을 설정해봐도 좋을 것 같습니다~!!
There was a problem hiding this comment.
아이쿠 여기도 수정한다는 걸 깜빡했네요!! 확인 감사합니다!!
leeminhee119
force-pushed
the
feature/#11/input
branch
from
e347b70 to
3b70ba1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏄🏼♂️ Summary (요약)
🫨 Describe your Change (변경사항)
관련 변경 파일들입니다!
InputLabelContainer에 id를 전달하면 라벨과 인풋에 해당 id가 부여됩니다.InputLabelContainer에는 라벨과 인풋을 감싸는 부모 엘리먼트를 포함합니다. (간격 스타일 포함)Label의orderprop 은 라벨에 포함될 넘버링을 나타냅니다. 전달하지 않으면 넘버링 없이 텍스트 라벨만 출력됩니다. (아래 예시)🧐 Issue number and link (참고)
📚 Reference (참조)