Skip to content

Commit

Permalink
Ensure relative paths resolve properly. Fixes #49
Browse files Browse the repository at this point in the history
  • Loading branch information
mrjoelkemp committed Feb 14, 2015
1 parent e5fedeb commit 69eb9df
Show file tree
Hide file tree
Showing 5 changed files with 34 additions and 16 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
},
"devDependencies": {
"jscs": "~1.7.3",
"mocha": "~1.21.4",
"mocha": "~2.1.0",
"sinon": "~1.12.2"
}
}
1 change: 1 addition & 0 deletions test/example/nestedsass/a/a.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
@import "../styles";
2 changes: 2 additions & 0 deletions test/example/nestedsass/a/b/b.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
@import "../../styles";
@import "../a";
3 changes: 3 additions & 0 deletions test/example/nestedsass/styles.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
body {
color: vomit;
}
42 changes: 27 additions & 15 deletions test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@ var assert = require('assert');
var defaultExclusions = require('../lib/util').DEFAULT_EXCLUDE_DIR;
var sinon = require('sinon');

function listHasFile(list, file) {
return list.some(function(f) {
return f.indexOf(file) !== -1;
});
}

describe('dependents', function() {
it('reuses a given configuration object config', function(done) {
var config = dependents._readConfig(__dirname + '/example/amd/config.json');
Expand Down Expand Up @@ -79,9 +85,7 @@ describe('dependents', function() {
directory: __dirname + '/example/exclusions',
exclusions: ['customExclude'],
success: function(err, dependents) {
assert(!dependents.some(function(dependent) {
return dependent.indexOf('customExclude') !== -1;
}));
assert(!listHasFile(dependents, 'customExclude'));
done();
}
});
Expand All @@ -94,9 +98,7 @@ describe('dependents', function() {
directory: __dirname + '/example/exclusions',
exclusions: ['customExclude/subdir'],
success: function(err, dependents) {
assert(dependents.some(function(dependent) {
return dependent.indexOf('customExclude/subdir') !== -1;
}));
assert(listHasFile(dependents, 'customExclude/subdir'));
done();
}
});
Expand All @@ -110,7 +112,7 @@ describe('dependents', function() {
directory: __dirname + '/example/amd',
success: function(err, dependents) {
assert(dependents.length === 1);
assert(dependents[0].indexOf('a.js') !== -1);
assert(listHasFile(dependents, 'a.js'));
done();
}
});
Expand All @@ -123,8 +125,8 @@ describe('dependents', function() {
config: __dirname + '/example/amd/config.json',
success: function(err, dependents) {
assert(dependents.length === 2);
assert(dependents[0].indexOf('a.js') !== -1);
assert(dependents[1].indexOf('c.js') !== -1);
assert(listHasFile(dependents, 'a.js'));
assert(listHasFile(dependents, 'c.js'));
done();
}
});
Expand All @@ -148,9 +150,7 @@ describe('dependents', function() {
filename: __dirname + '/example/commonjs/b.js',
directory: __dirname + '/example/commonjs',
success: function(err, dependents) {
assert(dependents.some(function(d) {
return d.indexOf('c.js') !== -1;
}));
assert(listHasFile(dependents, 'c.js'));
done();
}
});
Expand Down Expand Up @@ -187,9 +187,21 @@ describe('dependents', function() {
filename: __dirname + '/example/sass/_foo.scss',
directory: __dirname + '/example/sass',
success: function(err, dependents) {
assert(dependents.some(function(dep) {
return dep.indexOf('stylesUnderscore.scss') !== -1;
}));
assert(listHasFile(dependents, 'stylesUnderscore.scss'));
done();
}
});
});

it('handles deeply nested paths', function(done) {
dependents({
filename: __dirname + '/example/nestedsass/styles.scss',
directory: __dirname + '/example/nestedsass',
success: function(err, dependents) {
assert(!err);
assert(dependents.length);
assert(listHasFile(dependents, 'b.scss'));
assert(listHasFile(dependents, 'a.scss'));
done();
}
});
Expand Down

0 comments on commit 69eb9df

Please sign in to comment.