Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade httparty to 0.22.0 #9906

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

deivid-rodriguez
Copy link
Contributor

What are you trying to accomplish?

Warnings due to using old httparty were partially fixed by #9770.

However, you still get runtime warnings like the following:

    updater | /home/dependabot/dependabot-updater/vendor/ruby/3.3.0/gems/httparty-0.21.0/lib/httparty.rb:10: warning: csv was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add csv to your Gemfile or gemspec. Also contact author of httparty-0.21.0 to add csv into its gemspec.

because the update was not applied to updater/ folder.

This PR also updates the dependency in updater/Gemfile.lock.

Anything you want to highlight for special attention from reviewers?

Follow up to #9770 and #9873.

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner June 5, 2024 18:04
@deivid-rodriguez
Copy link
Contributor Author

For what it's worth, I took a look at release notes and I don't see anything that could harm, it seems mostly bug fixes and no regressions reported since released last april.

Fixes runtime warnings like the following:

```
updater | /home/dependabot/dependabot-updater/vendor/ruby/3.3.0/gems/httparty-0.21.0/lib/httparty.rb:10: warning: csv was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add csv to your Gemfile or gemspec. Also contact author of httparty-0.21.0 to add csv into its gemspec.
```
@kbukum1 kbukum1 merged commit 54df455 into dependabot:main Jun 25, 2024
104 checks passed
@deivid-rodriguez deivid-rodriguez deleted the httparty-0.22.0-updater branch June 25, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants