Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds telemetry collection logs for existing branches information #10840

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

sachin-sandhu
Copy link
Contributor

@sachin-sandhu sachin-sandhu commented Oct 24, 2024

What are you trying to accomplish?

This is related with #10519 , As there seems to be an issue with sending and receiving args from api, we are adding additional logs to better collect and validate data exchange between API and core.

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@sachin-sandhu sachin-sandhu self-assigned this Oct 24, 2024
@sachin-sandhu sachin-sandhu changed the title draft changes Adds telemetry collection logs for existing branches information Oct 24, 2024
@sachin-sandhu sachin-sandhu marked this pull request as ready for review October 24, 2024 03:27
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner October 24, 2024 03:27
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/adds-logs-for-existing-branches branch from 5d466e0 to 9d9b298 Compare October 24, 2024 14:55
@Nishnha
Copy link
Member

Nishnha commented Oct 24, 2024

Since we are using this for debugging purposes, I think we should use Dependabot.logger.debug instead of Dependabot.logger.info.

Debugging can be enabled on a repo with the debug_logging feature flag

@sachin-sandhu sachin-sandhu merged commit 4727f38 into main Oct 24, 2024
142 checks passed
@sachin-sandhu sachin-sandhu deleted the ssandhu/adds-logs-for-existing-branches branch October 24, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants