-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling the RSpec BeforeAfterAll Rubocop rule #10006
Conversation
5590c14
to
fd33f8b
Compare
23b8528
to
e62c5ba
Compare
Some of the rubocops were mixed up in main, so with a merge from main, things got out of sync. This branch should reflect the rubocop status in main. |
@GarryHurleyJr still looks like there are unrelated changes in this PR. Maybe easiest to just do a hard reset to main and re-apply the changes. |
b4d9711
to
6f19702
Compare
The problem is that PR #9820 re-added some other rubocop rules that had been removed. I have updated that here so that we are at least showing the proper status of rubocop_todo.yml. Alternatively, I coud peel out those changes into a separate PR to merge into main and keep this and other PR's clean. |
* Strict type Dependabot::Bundler::ChildGemFileFinder. * Strict type Dependabot::Bundler::ChildGemfileFinder.
#10041 contains the code that was muddying this PR. |
creating a new PR for this issue |
https://www.rubydoc.info/gems/rubocop-rspec/1.15.0/RuboCop/Cop/RSpec/BeforeAfterAll
What are you trying to accomplish?
The BeforeAfterAll RSpec rule was disabled in some parts of the ecosystme. This PR will enable and fix those scenarios it identifies.
Anything you want to highlight for special attention from reviewers?
Please watch for code duplications or conflicts.
How will you know you've accomplished your goal?
The Rubocop rule will work and the tests will not fai afterwards.
Checklist