Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2137 - Update logging statements to capture notification status #2164

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

MackHalliday
Copy link

@MackHalliday MackHalliday commented Dec 5, 2024

Description

issue #2137

Update logging statement to capture notification status

How Has This Been Tested?

  • Called v2/notification/sms with invalid phone and checked logs
Screenshot 2024-12-05 at 12 40 34 PM Screenshot 2024-12-05 at 12 40 28 PM

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket was moved into the DEV test column when I began testing this change

k-macmillan
k-macmillan previously approved these changes Dec 5, 2024
kalbfled
kalbfled previously approved these changes Dec 5, 2024
@MackHalliday MackHalliday dismissed stale reviews from kalbfled and k-macmillan via 5f391b2 December 5, 2024 20:56
@MackHalliday MackHalliday force-pushed the 2137-send-va-profile-sms-delivery-status-updates branch from 901e62f to 5f391b2 Compare December 5, 2024 20:56
@k-macmillan k-macmillan merged commit cc9a627 into main Dec 5, 2024
5 checks passed
@k-macmillan k-macmillan deleted the 2137-send-va-profile-sms-delivery-status-updates branch December 5, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants