drop deprecated imp module use #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The imp module is deprecated and will be removed in the future, so add an API compatible load_source() helper function to poe_common.py. Signed-off-by: Jonas Gorski <[email protected]>
Drop the deprecated import and switch to the new helper function. Silences the following warning on start up: > Sep 21 13:11:59 localhost systemd[1]: Started DentOS POE Agent. > Sep 21 13:11:59 localhost poed[938]: poed.py:28: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses > Sep 21 13:11:59 localhost poed[938]: import imp Signed-off-by: Jonas Gorski <[email protected]>
Drop the deprecated import and switch to the new helper function. Silences the following warning on start up: > root@localhost:~# poecli > poecli.py:26: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses > import imp Signed-off-by: Jonas Gorski <[email protected]>
taraschornyiplv
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the deprecated
imp.load_source()with a helper function imitating it to fix the warning on startup.The replacement works with Python 3.5+, which should be fine, since this is the version in Debian 9, while Debian 10 even has Python 3.7.
Note that this is not fully run-tested, since I do not have access to a PoE capable machine, but at least loading a dummy
poe_platform.pythat prints something in itsget_poe_platform()did produce the expected output.