fix!(biome): allow passing options to biome check
#4799
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only option available to biome's
lsp-proxy
command used for linting is--config-path
. However, we are using ALE to find and set the project root, and have a way to manually override, so that is no longer necessary.The LSP proxy also used the
g:ale_biome_options
config, which is shared with the fixer'scheck
command, butlsp-proxy
will throw an error if unknown options are included, making it so that option is only useful to set the project root.BREAKING CHANGE: We are no longer passing options to the biome LSP proxy, but we can still set the project root with
g:ale_biome_lsp_project_root
.I added a test that shows you can pass arbitrary options along to
biome check
and updated the documentation.I had thought about continuing to pass
g:ale_biome_options
to the LSP for backwards compatibility and t hen creating a newg:ale_biome_fixer_options
that get added additionally to the fixer, but that seemed a lot more complex. Considering the only shared option is--config-path
, which is also the only LSP option, people either were only using that option or their LSP would have been broken.The downside to this approach is that if someone is relying on
--config-path
they may need to update to useale_biome_lsp_project_root
instead, so maybe a deprecation path is better. @w0rp @hsanson, what do you think?