feat: add void to PythonConverible (#57)

denosaurs · Nov 13, 2023 · f1af5b1 · f1af5b1
1 parent 025e9da
commit f1af5b1
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/python.ts b/src/python.ts
@@ -61,6 +61,7 @@ export interface PythonProxy {
 export type PythonConvertible =
   | number
   | bigint
+  | void
   | null
   | undefined
   | boolean
@@ -434,7 +435,7 @@ export class PyObject {
       }
 
       case "object": {
-        if (v === null) {
+        if (v === null /*or void*/) {
           return python.builtins.None[ProxiedPyObject];
         } else if (ProxiedPyObject in v) {
           const proxy = v as PythonProxy;

diff --git a/test/test.ts b/test/test.ts
@@ -298,6 +298,21 @@ def call(cb):
   cb.destroy();
 });
 
+Deno.test("callback returns void", () => {
+  const { call } = python.runModule(
+    `
+def call(cb):
+  cb()
+  `,
+    "cb_test.py",
+  );
+  const cb = python.callback(() => {
+    // return void
+  });
+  call(cb);
+  cb.destroy();
+});
+
 Deno.test("exceptions", async (t) => {
   await t.step("simple exception", () => {
     assertThrows(() => python.runModule("1 / 0"));