Skip to content

docs(path): add many more examples to mod.ts #6569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

johnpyp
Copy link
Contributor

@johnpyp johnpyp commented Apr 11, 2025

This PR adds many more examples to path's front-page mod.ts.

Each example uses assertEquals to ensure correctness and testability.

@johnpyp johnpyp requested a review from kt3k as a code owner April 11, 2025 05:06
@CLAassistant
Copy link

CLAassistant commented Apr 11, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the path label Apr 11, 2025
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.22%. Comparing base (b5a5fe4) to head (82ba695).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6569   +/-   ##
=======================================
  Coverage   95.21%   95.22%           
=======================================
  Files         577      577           
  Lines       43381    43381           
  Branches     6487     6488    +1     
=======================================
+ Hits        41307    41308    +1     
+ Misses       2034     2033    -1     
  Partials       40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@johnpyp johnpyp force-pushed the docs/path-examples branch 2 times, most recently from b25d1d3 to a7de7aa Compare April 11, 2025 05:27
@johnpyp johnpyp force-pushed the docs/path-examples branch from a7de7aa to 82ba695 Compare April 11, 2025 05:35
@johnpyp
Copy link
Contributor Author

johnpyp commented Apr 11, 2025

Note: Basically all of these functions need a branch for windows-specific behavior to all pass CI, though it does make the example doc look a bit messier. Currently I've added branches for all of them, but if there's a preferred approach I'm all ears.

@johnpyp johnpyp changed the title docs(path): add many more examples to the main mod.ts docs(path): add many more examples to mod.ts Apr 11, 2025
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement for better visibility of the features in JSR module page! Thanks for your contribution

@kt3k kt3k merged commit 632691e into denoland:main Apr 15, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants