Skip to content

chore: add no-top-level-arrow-syntax rule to Deno Style Guide linter plugin #6558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 15, 2025

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Apr 8, 2025

Towards #6551

Blocked by denoland/deno#28799

@iuioiua iuioiua marked this pull request as ready for review April 8, 2025 13:26
@iuioiua iuioiua requested a review from kt3k as a code owner April 8, 2025 13:26
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 81.57895% with 7 lines in your changes missing coverage. Please review.

Project coverage is 94.58%. Comparing base (40da1fb) to head (e4368a6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
fs/_map_error.ts 25.00% 6 Missing ⚠️
_tools/lint_plugin.ts 95.83% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6558   +/-   ##
=======================================
  Coverage   94.57%   94.58%           
=======================================
  Files         579      579           
  Lines       43724    43752   +28     
  Branches     6492     6494    +2     
=======================================
+ Hits        41354    41381   +27     
- Misses       2330     2331    +1     
  Partials       40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iuioiua iuioiua changed the title chore: add no-top-level-arrow-syntax to Deno Style Guide linter plugin chore: add no-top-level-arrow-syntax rule to Deno Style Guide linter plugin Apr 9, 2025
@iuioiua
Copy link
Contributor Author

iuioiua commented Apr 10, 2025

This is only currently working on canary

@iuioiua iuioiua marked this pull request as draft April 10, 2025 12:17
@iuioiua
Copy link
Contributor Author

iuioiua commented Apr 10, 2025

Does this rule include non-exported arrow functions? The example snippet only exemplifies exported arrow functions.

@iuioiua iuioiua marked this pull request as ready for review April 13, 2025 23:38
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

@kt3k
Copy link
Member

kt3k commented Apr 15, 2025

Does this rule include non-exported arrow functions? The example snippet only exemplifies exported arrow functions.

I think this applies to non exported functions as well.

@kt3k kt3k merged commit cc488f3 into denoland:main Apr 15, 2025
18 checks passed
@iuioiua iuioiua deleted the no-top-level-arrow-syntax branch April 15, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants