Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fs/unstable): add statSync and lstatSync #6300

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Dec 24, 2024

This PR adds unstable statSync and lstatSync to @std/fs

towards #6255

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 47.22222% with 19 lines in your changes missing coverage. Please review.

Project coverage is 96.31%. Comparing base (d02d714) to head (6cbb389).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
fs/unstable_lstat.ts 50.00% 8 Missing ⚠️
fs/unstable_stat.ts 50.00% 8 Missing ⚠️
fs/_utils.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6300      +/-   ##
==========================================
- Coverage   96.34%   96.31%   -0.03%     
==========================================
  Files         547      547              
  Lines       41667    41691      +24     
  Branches     6314     6316       +2     
==========================================
+ Hits        40144    40156      +12     
- Misses       1481     1493      +12     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no comments

@kt3k kt3k merged commit 148107e into denoland:main Jan 10, 2025
18 checks passed
@kt3k kt3k deleted the fs-add-stat-sync-lstat-sync branch January 10, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants