Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): simplify and rename dropEndingNewline() #5336

Merged
merged 6 commits into from
Jul 7, 2024

Conversation

timreichen
Copy link
Contributor

@timreichen timreichen commented Jul 5, 2024

  • renames dropEndingNewline() to trimTrailingNewline()
  • uses .at(-1)
  • adds tests

@timreichen timreichen requested a review from kt3k as a code owner July 5, 2024 20:00
@github-actions github-actions bot added the yaml label Jul 5, 2024
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.81%. Comparing base (5cccc4b) to head (85fbe41).

Files Patch % Lines
yaml/_dumper.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5336      +/-   ##
==========================================
+ Coverage   95.80%   95.81%   +0.01%     
==========================================
  Files         458      458              
  Lines       37871    37869       -2     
  Branches     5562     5562              
==========================================
+ Hits        36283    36285       +2     
+ Misses       1548     1544       -4     
  Partials       40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k merged commit 424a113 into denoland:main Jul 7, 2024
13 checks passed
@timreichen timreichen deleted the yaml-rename-dropEndingNewline branch July 7, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants