Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(yaml): test stringify() case when string encoded into hex sequences #5230

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jul 1, 2024

part of #3713

This PR adds the test cases of stringify when the output is hex encoded strings.

@github-actions github-actions bot added the yaml label Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.94%. Comparing base (19be4f8) to head (9ba3e62).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5230      +/-   ##
==========================================
+ Coverage   94.82%   94.94%   +0.12%     
==========================================
  Files         461      461              
  Lines       38089    38089              
  Branches     5514     5549      +35     
==========================================
+ Hits        36118    36164      +46     
+ Misses       1933     1884      -49     
- Partials       38       41       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cute cat. LGTM.

@iuioiua iuioiua changed the title test(yaml): test the case when string encoded into hex sequences test(yaml): test stringify() case when string encoded into hex sequences Jul 1, 2024
@kt3k kt3k merged commit 442b018 into denoland:main Jul 1, 2024
16 checks passed
@kt3k kt3k deleted the test-yaml-stringify-encoding branch July 1, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants