Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(fs): improve ensureSymlink() test #5087

Merged
merged 2 commits into from
Jun 20, 2024
Merged

test(fs): improve ensureSymlink() test #5087

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
771ab20
test(fs): improve ensureSymlink test
kt3k Jun 19, 2024
f408442
skip some test on windows
kt3k Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion fs/ensure_symlink_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,10 @@ Deno.test("ensureSymlinkSync() creates symlink with relative target", function (
Deno.removeSync(testDir, { recursive: true });
});

Deno.test("ensureSymlink() works with URLs", async () => {
Deno.test("ensureSymlink() works with URLs", {
// TODO(kt3k): The 2nd test case doesn't pass on Windows. Fix it.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Able to create an issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #5092

ignore: Deno.build.os === "windows",
}, async () => {
const testDir = path.join(testdataDir, "link_file_with_url");
const testFile = path.join(testDir, "test.txt");
const linkFile = path.join(testDir, "link.txt");
Expand Down