Write librusty_v8.a sha-256 checksum to file.

[bnoordhuis]

No description provided.

[piscisaureus]

What's the purpose of this change?
I suspect it has something to do with re-downloading librusty_v8.a after upgrading the rusty_v8 crate.
But there is no way for build.rs to know the "correct" shasum so I don't see how it would work...

[bartlomieju]

@piscisaureus #545

[piscisaureus]

@bartlomieju

There is no way for build.rs to know the "correct" shasum so I don't see how it would work. The only way to find out would be to download the .shasum file on every build, but this will make people that use a mirror unhappy.

My suggestion would be to append the crate version to the filename instead.

[bartlomieju]

The only way to find out would be to download the .shasum file on every build, but this will make people that use a mirror unhappy.

That was the plan to download checksum alongside static lib and verify that checksum of static lib's checksum matches. Probably could skip it for mirrors?

[piscisaureus]

@bartlomieju

Right - so this is not intended to solve the issue that the static library build should be re-downloaded after a rusty_v8 upgrade?

I am aware that some people experience link errors, but that's pretty much always because the download failed entirely and left an empty librusty_v8.a in the build directory. There's no need for shasumming to detect that.

[bnoordhuis]

so this is not intended to solve the issue that the static library build should be re-downloaded after a rusty_v8 upgrade?

No, it's to catch partial or corrupted downloads.

[bnoordhuis]

Ping @piscisaureus - your thoughts?

[ry]

It's rather unfortunate that this patch adds a bunch of dependencies just to calculate the checksum.

https://crates.io/crates/sha1 for example is self-contained. Maybe we could use that - or an already installed command-line utility?

[ry]

Closing because stale.