fix: ExternalOneByteStringResource is not guaranteed to be valid UTF-8 #1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #1531? |
Oh, yes |
0f-0b
reviewed
Jul 19, 2024
bartlomieju
approved these changes
Jul 19, 2024
I couldn't give a full "yes" so I fixed the code to check for length being zero. If length is zero, then the pointer could also theoretically be null. |
bartlomieju
added a commit
to denoland/deno_core
that referenced
this pull request
Jul 22, 2024
Includes: - denoland/rusty_v8#1532 - denoland/rusty_v8#1533 Closes #834
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A subtle unsoundness / undefined behaviour made its way into the fairly recently added
ExternalOneByteStringResourceobject: Theas_strAPI is not sound as the data inside may be be Latin-1, not ASCII.As the API was not used anywhere in deno or deno_core, I opted to simply remove it and replace it with an
as_bytesAPI. I also modified the test to showcase the Latin-1 string case and added copious notes and explanations around the code to make sure this doesn't accidentally happen again. The likely reason why the API originally slipped in is because theOneByteConsthas this API where it is safe because theOneByteConstcreation checks the data for ASCII-ness.I also tried to add an API to extract an
Option<&'static OneByteConst>from an&ExternalOneByteStringResourcebut run into rust-lang/rust#119618 ie. OneByteConst is actually duplicating the vtables... which is not great.Closes #1531