For #970 & #1303 : Enable build for aarch64-linux-android & x86_64-linux-android #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Looks reasonable to me. Will run the build and confirm. |
This was referenced May 11, 2024
|
You skip |
|
Is there any way to solve the one-byte const crash problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cross build for x64 android and arm64 android.
Tests skipped pass on a real device, the qemu trigger overflow due to some issues on the memory mapping.
Confirmed by littledivy and me.
Passed CI: https://github.com/Taknok/rusty_v8/actions/runs/8764258824
Related issues:
#970
#1303