fix: make Eternal::get return an Option instead

denoland · Dec 31, 2024 · f181726 · f181726
1 parent f830de5
commit f181726
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/handle.rs b/src/handle.rs
@@ -1147,7 +1147,7 @@ impl<T> Eternal<T> {
     }
   }
 
-  pub fn get<'s>(&self, scope: &mut HandleScope<'s, ()>) -> Local<'s, T> {
+  pub fn get<'s>(&self, scope: &mut HandleScope<'s, ()>) -> Option<Local<'s, T>> {
     unsafe {
       scope
         .cast_local(|sd| {
@@ -1156,7 +1156,6 @@ impl<T> Eternal<T> {
             sd.get_isolate_ptr(),
           ) as *const T
         })
-        .unwrap()
     }
   }
 

diff --git a/tests/test_api.rs b/tests/test_api.rs
@@ -11990,14 +11990,16 @@ fn test_eternals() {
     let str1 = v8::String::new(&mut scope, "hello").unwrap();
 
     assert!(eternal1.is_empty());
+    assert!(eternal1.get(&mut scope).is_none());
     eternal1.set(&mut scope, str1);
     assert!(!eternal1.is_empty());
 
-    let str1_get = eternal1.get(&mut scope);
+    let str1_get = eternal1.get(&mut scope).unwrap();
     assert_eq!(str1, str1_get);
 
     eternal1.clear();
     assert!(eternal1.is_empty());
+    assert!(eternal1.get(&mut scope).is_none());
   }
 
   // Try all 'standalone' methods after isolate has dropped.