fix(plugins/fs_routes): error when exporting middleware array with createDefine().middleware
#2799
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the docs of
createDefine().middleware
, it accepts a single function or an array of functions. But if you actually default export something like this:you get this error:
For this reason, I updated the
isFreshFile
function to also allow a non empty array of functions. I also added tests and updated types surrounding it, unfortunately this led to a lot of lines insrc/plugins/fs_routes/mod_test.tsx
type-erroring "Parameter 'ctx' implicitly has an 'any' type", but I was unable to fix that with my little TS knowledge.