Add WebSocket server throughput bench (#2741)

denoland · Apr 5, 2023 · 4dbfc34 · 4dbfc34
1 parent 65e34d8
commit 4dbfc34
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/routes/benchmarks.tsx b/routes/benchmarks.tsx
@@ -120,13 +120,31 @@ export default function Benchmarks({ url, data }: PageProps<Data>) {
               ? benchData.normalizedMaxLatency
               : benchData.maxLatency}
             yLabel="milliseconds"
-            yTickFormat={formatMsec}
+            yTickFormat={formatReqSec}
           />
           <p class="mt-1">
             Max latency during the same test used above for requests/second.
             Smaller is better.
           </p>
         </div>
+        <div class="mt-8">
+          <a href="#ws-echo-throughput" id="ws-echo-throughput">
+            <h5 class="text-lg font-medium tracking-tight hover:underline">
+              WebSocket Server Throughput
+            </h5>
+          </a>{" "}
+          <BenchmarkChart
+            columns={normalized
+              ? benchData.normalizedMsgPerSec
+              : benchData.msgPerSec}
+            yLabel="1k msg/sec"
+            yTickFormat={formatReqSec}
+          />
+          <p class="mt-1">
+            Tests WebSocket server performance. 100 concurrent connections do as
+            many echo requests as possible. Bigger is better.
+          </p>
+        </div>
       </div>
     );
   }

diff --git a/utils/benchmark_utils.ts b/utils/benchmark_utils.ts
@@ -35,6 +35,7 @@ export interface BenchmarkRun {
   thread_count?: BenchmarkVariantsResultSet;
   throughput?: BenchmarkVariantsResultSet;
   lsp_exec_time?: BenchmarkVariantsResultSet;
+  ws_msg_per_sec?: BenchmarkVariantsResultSet;
 }
 
 export type BenchmarkName = Exclude<keyof BenchmarkRun, "created_at" | "sha1">;
@@ -328,6 +329,8 @@ export interface BenchmarkData {
   cargoDeps: Column[];
   sha1List: string[];
   lspExecTime: Column[];
+  msgPerSec: Column[];
+  normalizedMsgPerSec: Column[];
 }
 
 export function reshape(data: BenchmarkRun[]): BenchmarkData {
@@ -338,6 +341,7 @@ export function reshape(data: BenchmarkRun[]): BenchmarkData {
 
   const normalizedReqPerSec = createNormalizedColumns(data, "req_per_sec");
   const normalizedMaxLatency = createNormalizedColumns(data, "max_latency");
+  const normalizedMsgPerSec = createNormalizedColumns(data, "ws_msg_per_sec");
 
   return {
     execTime: createColumns(
@@ -353,6 +357,8 @@ export function reshape(data: BenchmarkRun[]): BenchmarkData {
     throughput: createColumns(data, "throughput"),
     reqPerSec: createColumns(data, "req_per_sec"),
     normalizedReqPerSec,
+    msgPerSec: createColumns(data, "ws_msg_per_sec"),
+    normalizedMsgPerSec,
     proxy: createColumns(data, "req_per_sec_proxy"),
     maxLatency: createColumns(data, "max_latency"),
     normalizedMaxLatency,