Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: flatten namespaces on index pages #29

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Dec 6, 2021

Ref #3

This is part 1 of what I suggested in #3, where namespaces are flattened on the index page, so "all" symbols are listed.

Here is what it looks like for /deno/stable now:

Deno_Doc_-_deno_stable_

And here is what it looks like for oak:

Cursor_and_Deno_Doc_-_https___deno_land_x_oak_mod_ts

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this really helps with navigability.

Also kudos to how easy it is to do local development! Just checked out the repo and executed ./main.ts and everything just works. Very nice :-)

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, great improvement

@kitsonk
Copy link
Contributor Author

kitsonk commented Dec 6, 2021

Ok, I will write up some tests then this morning.

@kitsonk kitsonk marked this pull request as ready for review December 6, 2021 22:05
@kitsonk kitsonk merged commit 7411a36 into denoland:main Dec 6, 2021
@kitsonk kitsonk deleted the feat_flatten_namespace branch December 6, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants