Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose a version of prepare stack trace callback that doesn't patch callsites #962

Merged

Conversation

nathanwhit
Copy link
Member

@nathanwhit nathanwhit commented Nov 13, 2024

this PR has no effect on the CLI, but exposing this allows deploy to avoid patching callsites on old deployments.

Basically in deploy, when creating the isolate I would expect something like

if !is_new_deployment {
  isolate.set_prepare_stack_trace_callback(
    deno_core::error::prepare_stack_trace_callback_with_original_callsites
  );
}

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.75758% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.32%. Comparing base (0c7f83e) to head (5ecfe5d).
Report is 163 commits behind head on main.

Files with missing lines Patch % Lines
core/error.rs 75.75% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #962      +/-   ##
==========================================
- Coverage   81.43%   81.32%   -0.12%     
==========================================
  Files          97       97              
  Lines       23877    25002    +1125     
==========================================
+ Hits        19445    20333     +888     
- Misses       4432     4669     +237     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanwhit nathanwhit merged commit 7a35fd9 into denoland:main Nov 18, 2024
18 checks passed
@nathanwhit nathanwhit deleted the expose-prepare-stack-trace-without-patch branch November 18, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants