Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] implement Storage APIs. localStorage/sessionStorage #3525

Closed
wants to merge 5 commits into from
Closed

[WIP] implement Storage APIs. localStorage/sessionStorage #3525

wants to merge 5 commits into from

Conversation

axetroy
Copy link
Contributor

@axetroy axetroy commented Dec 19, 2019

ref: #1657

depends on: rusty-leveldb

leveldb storage at dir $DENO_DIR/storage/localstorage/:origin

TODO:

  • window complatible
  • implement domain origin isolation.

eg deno run --origin=example.com xxx.ts ?

  • Combine multiple dispatch to one

  • if origin does not exist, use pid for isolation

  • test case

  • Explore possible conflicts caused by using the same origin in multiple processes

eg, there are multiple processes run with this.

deno run --origin=my.domain.com local_storage_set_item.ts

multiple processes write to the same leveldb, which may cause problems

@axetroy axetroy changed the title [WPI] implement Storage APIs. localStorage/sessionStorage [WIP] implement Storage APIs. localStorage/sessionStorage Dec 19, 2019
@axetroy
Copy link
Contributor Author

axetroy commented Dec 22, 2019

I contacted the author of rusty-leveldb and hoped to be able to support Window. Before that, temporarily close this PR.

@axetroy axetroy closed this Dec 22, 2019
@rektide
Copy link

rektide commented Jan 31, 2020

Pardon this is rude and or unhelpful, but I might recommend Sled as the hot new LevelDB-ish replacement that's getting a ton of active development, looks super fast, is cross platform, in general, looks super hip.
https://github.com/spacejam/sled

@kitsonk
Copy link
Contributor

kitsonk commented Feb 1, 2020

Interesting...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants