Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App 1535 optimize lazyload #3

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

willhowlett
Copy link

No description provided.

@majda
Copy link

majda commented Nov 5, 2020

@willhowlett Since this PR is about optimization, do you mind if I also comit one miror change (in separate PR), which is related with performance?
It is about changing the host of the gpt.js script.

https://dennisltd.slack.com/archives/C36ECG5RD/p1604477768053900

https://developers.google.com/publisher-ads-audits/reference/audits/loads-gpt-from-sgdn

"The Google Publisher Tag library is now hosted at https://securepubads.g.doubleclick.net/tag/js/gpt.js, in addition to being hosted at the googletagservices.com domain. While not required, we strongly recommend that you update all references to GPT on your pages to use this new domain.
This change consolidates all ad serving requests to one domain, instead of two, which means the browser only needs to connect to one domain. The library is exactly the same at both domains.
The result is an improvement in the speed of your tags and fetching ads a bit quicker."

My PR: #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants