Skip to content

Commit

Permalink
Merge pull request #6 from dennisinteractive/bug/APP-1715-revert-chan…
Browse files Browse the repository at this point in the history
…ge-done-in-APP-1677

APP-1715 - Revert changes done as part of APP-1677
  • Loading branch information
majda authored Mar 7, 2021
2 parents 6a8b18d + 541022e commit fd74491
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion docs/api/ReactGPT.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ React GPT makes sure that those APIs are called right before the service is enab

Global configuration applies to the all React GPT instances. You can set the following configuration through `Bling.configure(config)`.

- `seedFileUrl` - An optional string for GPT seed file url to override. Default value is `//www.googletagservices.com/tag/js/gpt.js`.
- `seedFileUrl` - An optional string for GPT seed file url to override. Default value is `https://securepubads.g.doubleclick.net/tag/js/gpt.js`.
- `renderWhenViewable` - An optional flag to indicate whether an ad should only render when it's fully in the viewport area. Default is `true`.
- `viewableThreshold` - An optional number to indicate how much percentage of an ad area needs to be in a viewable area before rendering. Default value is `0.5`. Acceptable range is between `0` and `1.0`.
- `filterProps` - An optional function to create an object with filtered current props and next props for a given keys to perform equality check. Default value is [`filterProps`](../../src/utils/filterProps.js).
Expand Down
2 changes: 1 addition & 1 deletion lib/Bling.js
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ var Bling = (_temp2 = _class = function (_Component) {
slotSize = sizeMapping[0] && sizeMapping[0].slot;
}

return JSON.stringify(slotSize) === "[0,0]" ? [] : slotSize;
return slotSize;
}
}, {
key: "renderAd",
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@dennisinteractive/react-gpt",
"version": "2.2.1",
"version": "2.2.2",
"description": "A react display ad component using Google Publisher Tag",
"main": "lib/index.js",
"jsnext:main": "es/index.js",
Expand Down
2 changes: 1 addition & 1 deletion scripts/updateAPIList.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ phantom.create().then(function (ph) {
}
});
page.open(process.cwd() + "/scripts/empty.html").then(function () {
page.includeJs("http://www.googletagservices.com/tag/js/gpt.js").then(function () {
page.includeJs("https://securepubads.g.doubleclick.net/tag/js/gpt.js").then(function () {
setTimeout(function () {
page.evaluate(function () {
var EXCLUDES = ["constructor"].concat(Object.getOwnPropertyNames(Object.getPrototypeOf({})));
Expand Down
2 changes: 1 addition & 1 deletion src/Bling.js
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@ class Bling extends Component {
slotSize = sizeMapping[0] && sizeMapping[0].slot;
}

return JSON.stringify(slotSize) === "[0,0]" ? [] : slotSize;
return slotSize;
}

renderAd() {
Expand Down
2 changes: 1 addition & 1 deletion test/createManager.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ describe("createManager", () => {

it("loads gpt", done => {
adManager
.load("//www.googletagservices.com/tag/js/gpt.js")
.load("https://securepubads.g.doubleclick.net/tag/js/gpt.js")
.then(result => {
expect(result).to.be.an("object");
expect(adManager.isLoaded).to.be.true;
Expand Down

0 comments on commit fd74491

Please sign in to comment.