Permit use of Secrets instead of inline text for iSCSI authentication #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch creates a new key under storageClasses for
existingSecret
where for each of thesecrets
can be provided directly (name and namepace) instead of managed by the chart. E.g.:The secret must be contain validly formatted keys. E.g.:
I chose to implement this as "all or nothing" regarding secrets management, with the belief that if someone is already in the weeds for one of the secrets, they would likely manually define all. So if the
existingSecrets
value exists (for a specific StorageClass), you must define all of the secrets that are necessary for that class. (Though some StorageClasses might useexistingSecrets
and others could usesecrets
--though I don't know why anyone would do that.)I made this patch as I wasn't able to get any sort of secret injection to properly work on the existing implementation, and found several people referencing that they just encrypt the plain-text credentials in place. That seemed inelegant to me, given there is an entire secrets ecosystem in k8s (and I prefer to use ExternalSecrets to manage as much as possible.)
I'd be happy to write an update to the values file to reflect these changes if you find this PR suitable for inclusion.