Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incapsula - pass arguments in url params #37126

Merged
merged 3 commits into from
Nov 10, 2024
Merged

Incapsula - pass arguments in url params #37126

merged 3 commits into from
Nov 10, 2024

Conversation

adi88d
Copy link
Contributor

@adi88d adi88d commented Nov 7, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Fixed an issue where the commands' args were not parsed as expected.

Must have

  • Tests
  • Documentation

Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@adi88d
Copy link
Contributor Author

adi88d commented Nov 10, 2024

Need a force merge since we dont have a tests or credentials to this integration,
Tested it with the customer and confirmed that it works as expected.
@DeanArbel FYI

@DeanArbel DeanArbel added the ForceMerge Forcing the merge of the PR despite the build status label Nov 10, 2024
@DeanArbel DeanArbel merged commit 399974c into master Nov 10, 2024
19 of 20 checks passed
@DeanArbel DeanArbel deleted the Incapsula-fix branch November 10, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants