Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc class based syntax clean up #1880

Merged
merged 18 commits into from
Jul 15, 2024
Merged

Misc class based syntax clean up #1880

merged 18 commits into from
Jul 15, 2024

Conversation

bdemann
Copy link
Member

@bdemann bdemann commented Jul 9, 2024

No description provided.

This was linked to issues Jul 9, 2024
Make system types go away, just use them where they are needed and duplicate if needed (but you probably wont have to) #1879
Closed
stable_read is depricated #1878
Closed
Notify raw needs to be collapsed into notify #1877
Closed
Consolidate canisterBalance128 and canisterBalance into one function that just calls canisterBalance128 under the hood #1875
Closed
Have ic_apis return actual default values instead of undefined #1876
Closed
@bdemann bdemann force-pushed the class_based_cleanup branch from 44ff71b to e8a91f7 Compare July 10, 2024 20:08
@bdemann bdemann marked this pull request as draft July 12, 2024 16:46
@bdemann bdemann force-pushed the class_based_cleanup branch from e8a91f7 to c677495 Compare July 12, 2024 17:36
@bdemann bdemann force-pushed the class_based_cleanup branch from c677495 to fb080f6 Compare July 12, 2024 17:47
@bdemann bdemann marked this pull request as ready for review July 12, 2024 17:48
lastmjs
lastmjs requested changes Jul 12, 2024
View reviewed changes
examples/composite_queries/test/tests.ts Outdated Show resolved Hide resolved
examples/stable_memory/test/tests.ts Outdated Show resolved Hide resolved
src/compiler/generate_candid_and_canister_methods.ts Outdated Show resolved Hide resolved
examples/stable_memory/test/tests.ts Outdated Show resolved Hide resolved
src/lib/ic/call.ts Outdated Show resolved Hide resolved
src/lib/ic/reject_code.ts Show resolved Hide resolved
src/lib/stable/ic_apis/call.ts Outdated Show resolved Hide resolved
src/lib/stable/ic_apis/caller.ts Outdated Show resolved Hide resolved
src/lib/stable/ic_apis/id.ts Outdated Show resolved Hide resolved
tests/end_to_end/candid_rpc/class_syntax/notify_raw/src/canister1/index.ts Show resolved Hide resolved
lastmjs
lastmjs requested changes Jul 12, 2024
View reviewed changes
Copy link
Member

@lastmjs lastmjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use candidType and idlType convention everywhere

lastmjs
lastmjs previously approved these changes Jul 15, 2024
View reviewed changes
@bdemann bdemann force-pushed the class_based_cleanup branch from 165d579 to 4326a9c Compare July 15, 2024 16:50
@lastmjs lastmjs merged commit 93b5c56 into main Jul 15, 2024
58 of 60 checks passed
@bdemann bdemann deleted the class_based_cleanup branch July 19, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lastmjs lastmjs lastmjs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bdemann @lastmjs