fix chunking instruction limit issue

demergent-labs · Dec 31, 2024 · 631bba7 · 631bba7
1 parent 452022a
commit 631bba7
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 1 deletion.
diff --git a/canister_templates/experimental.wasm b/canister_templates/experimental.wasm
diff --git a/canister_templates/stable.wasm b/canister_templates/stable.wasm
diff --git a/examples/stable/test/property/ic_api/chunk/src/index.ts b/examples/stable/test/property/ic_api/chunk/src/index.ts
@@ -47,7 +47,7 @@ async function sum(loops: number, shouldChunk: boolean): Promise<void> {
     for (let i = 0; i < loops; i++) {
         _sum += (i % 100) * (i % 100);
 
-        if (shouldChunk && i % 15_000_000 === 0) {
+        if (shouldChunk && i % 14_000_000 === 0) {
             await chunk();
         }
     }

diff --git a/examples/stable/test/property/ic_api/chunk/test/tests.ts b/examples/stable/test/property/ic_api/chunk/test/tests.ts
@@ -58,6 +58,9 @@ export function getTests(): Test {
             );
         });
 
+        // TODO this test will simply hang if it fails because timers don't throw any errors that we can catch
+        // TODO we would need to use the canister logs somehow to check if the timer has hit its instruction limit
+        // TODO but see this issue: https://forum.dfinity.org/t/no-instruction-limit-hit-canister-logs-within-timer/39518
         it('should not hit the instruction limit with chunking in a timer', async () => {
             const actor = await getCanisterActor<Actor>('canister');