Merge pull request #2400 from demergent-labs/default_decorators

Default decorators need not be invoked

examples/stable/test/end_to_end/candid_rpc/async_await/src/async_await.ts

@@ -26,7 +26,7 @@ export default class {
         ]);
     }
 
-    @update([])
+    @update
     async returnPromiseVoid(): Promise<void> {
         await call('aaaaa-aa', 'raw_rand', {
             returnIdlType: IDL.Vec(IDL.Nat8)

examples/stable/test/end_to_end/candid_rpc/candid_keywords/src/index.ts

@@ -100,7 +100,7 @@ type Candid = {
 };
 
 export default class {
-    @query([])
+    @query
     opt(): void {}
 
     @query([], CandidVariant)

examples/stable/test/end_to_end/candid_rpc/cross_canister_calls/src/canister1/index.ts

@@ -44,7 +44,7 @@ export default class {
         return (await call(this.canister2Id, 'trap')) as never;
     }
 
-    @update([])
+    @update
     sendNotification(): void {
         return notify(this.canister2Id, 'receiveNotification', {
             paramIdlTypes: [IDL.Text],

examples/stable/test/end_to_end/candid_rpc/cycles/src/intermediary/index.ts

@@ -12,7 +12,7 @@ export default class {
         });
     }
 
-    @update([])
+    @update
     sendCyclesNotify(): void {
         return notify(this.cyclesPrincipal, 'receiveCycles', {
             cycles: 1_000_000n

examples/stable/test/end_to_end/candid_rpc/func_types/canisters/func_types/index.ts

@@ -58,7 +58,7 @@ type NullFunc = Func;
 export default class {
     stableStorage = new StableBTreeMap<string, StableFunc>(0);
 
-    @init([])
+    @init
     init(): void {
         this.stableStorage.insert('stableFunc', [
             Principal.from('aaaaa-aa'),

examples/stable/test/end_to_end/candid_rpc/motoko_examples/calc/src/index.ts

@@ -34,7 +34,7 @@ export default class {
         }
     }
 
-    @update([])
+    @update
     clearall(): void {
         this.cell = 0n;
     }

examples/stable/test/end_to_end/candid_rpc/motoko_examples/counter/src/index.ts

@@ -13,7 +13,7 @@ export default class {
         this.counter = n;
     }
 
-    @update([])
+    @update
     inc(): void {
         this.counter += 1n;
     }

examples/stable/test/end_to_end/candid_rpc/motoko_examples/hello-world/src/index.ts

@@ -1,7 +1,7 @@
 import { query } from 'azle';
 
 export default class {
-    @query([])
+    @query
     main(): void {
         console.info('Hello World!');
     }

examples/stable/test/end_to_end/candid_rpc/motoko_examples/http_counter/src/index.ts

@@ -100,7 +100,7 @@ export type HttpResponse = {
 export default class {
     stableStorage = new StableBTreeMap<string, bigint>(0);
 
-    @init([])
+    @init
     init(): void {
         this.stableStorage.insert('counter', 0n);
     }

examples/stable/test/end_to_end/candid_rpc/motoko_examples/persistent-storage/src/index.ts

@@ -12,12 +12,12 @@ export default class {
     stableStorage = new StableBTreeMap<string, bigint>(0);
     redeployed = false;
 
-    @init([])
+    @init
     init(): void {
         this.stableStorage.insert('counter', 0n);
     }
 
-    @postUpgrade([])
+    @postUpgrade
     postUpgrade(): void {
         this.redeployed = true;
     }

examples/stable/test/end_to_end/candid_rpc/motoko_examples/simple-to-do/src/index.ts

@@ -55,7 +55,7 @@ export default class {
         return output;
     }
 
-    @update([])
+    @update
     clearCompleted(): void {
         // NOTE: this syntax isn't supported in Boa. If we revert to using Boa
         // we'll need to revert the syntax to:

examples/stable/test/end_to_end/candid_rpc/multi_deploy/src/index.ts

@@ -4,7 +4,7 @@ export default class {
     initCalled: boolean = false;
     postUpgradeCalled: boolean = false;
 
-    @init([])
+    @init
     init(): void {
         console.info('Init was called');
         this.initCalled = true;
@@ -21,7 +21,7 @@ export default class {
         return globalThis._azleInitCalled;
     }
 
-    @postUpgrade([])
+    @postUpgrade
     postUpgrade(): void {
         console.info('Post Upgrade was called');
         this.initCalled = false;

examples/stable/test/end_to_end/candid_rpc/notify_raw/src/canister1/index.ts

@@ -1,7 +1,7 @@
 import { candidEncode, notify, Principal, trap, update } from 'azle';
 
 export default class {
-    @update([])
+    @update
     sendNotification(): void {
         return notify(
             Principal.fromText(

examples/stable/test/end_to_end/candid_rpc/notify_raw/src/canister2/index.ts

@@ -3,7 +3,7 @@ import { IDL, query, update } from 'azle';
 export default class {
     notified: boolean = false;
 
-    @update([])
+    @update
     receiveNotification(): void {
         this.notified = true;
     }

examples/stable/test/end_to_end/candid_rpc/null_example/src/index.ts

@@ -37,7 +37,7 @@ export default class {
         return param;
     }
 
-    @query([])
+    @query
     voidIsNotNull(): void {
         print(
             'Even though they are both None in Python, for Candid null and void are different.'

examples/stable/test/end_to_end/candid_rpc/pre_and_post_upgrade/src/index.ts

@@ -24,14 +24,14 @@ export default class {
         [key: string]: bigint;
     } = {};
 
-    @init([])
+    @init
     init(): void {
         console.info('init');
 
         this.stableStorage.insert('entries', []);
     }
 
-    @postUpgrade([])
+    @postUpgrade
     postUpgrade(): void {
         console.info('postUpgrade');
 

examples/stable/test/end_to_end/candid_rpc/randomness/src/index.ts

@@ -3,7 +3,7 @@ import { IDL, postUpgrade, query, update } from 'azle';
 export default class {
     redeployed = false;
 
-    @postUpgrade([])
+    @postUpgrade
     postUpgrade(): void {
         this.redeployed = true;
     }

examples/stable/test/property/ic_api/caller/src/index.ts

@@ -20,7 +20,7 @@ export default class {
     preUpgradeCaller = new StableBTreeMap<'PRE_UPGRADE_CALLER', Principal>(0);
     inspectMessageCaller: Principal | null = null;
 
-    @init([])
+    @init
     init(): void {
         this.initCaller = caller();
     }
@@ -34,7 +34,7 @@ export default class {
         }
     }
 
-    @postUpgrade([])
+    @postUpgrade
     postUpgrade(): void {
         this.postUpgradeCaller = caller();
     }
@@ -76,7 +76,7 @@ export default class {
         }
     }
 
-    @update([])
+    @update
     setInspectMessageCaller(): void {
         this.inspectMessageCaller = caller();
     }

examples/stable/test/property/ic_api/canister_version/src/index.ts

@@ -23,7 +23,7 @@ export default class {
     inspectMessageCanisterVersion: bigint | null = null;
     meaninglessState: bigint = 0n;
 
-    @init([])
+    @init
     init(): void {
         this.initCanisterVersion = canisterVersion();
     }
@@ -37,7 +37,7 @@ export default class {
         }
     }
 
-    @postUpgrade([])
+    @postUpgrade
     postUpgrade(): void {
         this.postUpgradeCanisterVersion = canisterVersion();
     }
@@ -83,7 +83,7 @@ export default class {
         }
     }
 
-    @update([])
+    @update
     setInspectMessageCanisterVersion(): void {
         this.inspectMessageCanisterVersion = canisterVersion();
     }

examples/stable/test/property/ic_api/certified_data/src/index.ts

@@ -90,7 +90,7 @@ export default class {
         return certificate !== undefined ? [certificate] : [];
     }
 
-    @query([])
+    @query
     setDataCertificateInQuery(): void {
         setCertifiedData(new Uint8Array([3]));
     }

examples/stable/test/property/ic_api/id/src/index.ts

@@ -20,7 +20,7 @@ export default class {
     preUpgradeId = new StableBTreeMap<'PRE_UPGRADE_ID', Principal>(0);
     inspectMessageId: Principal | null = null;
 
-    @init([])
+    @init
     init(): void {
         this.initId = id();
     }
@@ -34,7 +34,7 @@ export default class {
         }
     }
 
-    @postUpgrade([])
+    @postUpgrade
     postUpgrade(): void {
         this.postUpgradeId = id();
     }
@@ -75,7 +75,7 @@ export default class {
         }
     }
 
-    @update([])
+    @update
     setInspectMessageId(): void {
         this.inspectMessageId = id();
     }

examples/stable/test/property/ic_api/reject_code/src/rejector/index.ts

@@ -11,6 +11,6 @@ export default class {
         reject('Rejection with message');
     }
 
-    @query([])
+    @query
     noError(): void {}
 }

examples/stable/test/property/ic_api/time/src/index.ts

@@ -17,12 +17,12 @@ import {
 import { AssertType, NotAnyAndExact } from 'azle/type_tests/assert_type';
 
 export default class {
-    // @init([])
+    // @init
     // init(): void {
     //     trap(`trapped from init`);
     // }
 
-    // @postUpgrade([])
+    // @postUpgrade
     // postUpgrade(): void {
     //     trap(`trapped from postUpgrade`);
     // }
@@ -41,7 +41,7 @@ export default class {
         }
     }
 
-    @update([])
+    @update
     inspectMessageTime(): void {}
 
     @query([], IDL.Nat64)

src/lib/stable/canister_methods/heartbeat.ts

@@ -1,31 +1,8 @@
-import { handleUncaughtError } from '../error';
-import { executeAndReplyWithCandidSerde } from '../execute_with_candid_serde';
+import { decoratorArgumentsHandler, MethodType } from '.';
 
 export function heartbeat<This, Args extends any[], Return>(
-    originalMethod: (this: This, ...args: Args) => Return,
+    originalMethod: MethodType<This, Args, Return>,
     context: ClassMethodDecoratorContext
 ): void {
-    const index = globalThis._azleCanisterMethodsIndex++;
-    const name = context.name as string;
-    const indexString = index.toString();
-
-    globalThis._azleMethodMeta.heartbeat = {
-        name,
-        index
-    };
-
-    globalThis._azleCallbacks[indexString] = async (): Promise<void> => {
-        try {
-            await executeAndReplyWithCandidSerde(
-                'heartbeat',
-                new Uint8Array(),
-                originalMethod.bind(globalThis._azleCanisterClassInstance),
-                [],
-                undefined,
-                false
-            );
-        } catch (error: any) {
-            handleUncaughtError(error);
-        }
-    };
+    decoratorArgumentsHandler('heartbeat', originalMethod, context);
 }